GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-101588: Deprecate pickle/copy/deepcopy support in itertools by rhettinger · Pull Request #104965 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented May 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thomas, the C code deprecation and the related tests were created in a way that should be easy to review and easy to turned-off if need arises.

  • Issue: Deprecate pickle support for itertools #101588

📚 Documentation preview 📚: https://cpython-previews--104965.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger added 4 commits May 25, 2023 21:38
@rhettinger
Add deprecations for itertool pickle support.
6b6aa77
@rhettinger
Limit category to a DeprecationWarnings
c24e293
@rhettinger
Expand warning message to cover copy and deepcopy as well
1687005
@rhettinger
Add whatsnew entry
ae7f17b
@rhettinger rhettinger added the needs backport to 3.12 only security fixes label May 26, 2023
@rhettinger
rhettinger requested a review from Yhg1s May 26, 2023 07:01
@bedevere-bot bedevere-bot added the awaiting core review label May 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2023
Deprecate pickle support for itertools #101588
Closed
Yhg1s
Yhg1s approved these changes May 26, 2023
View reviewed changes
Comment thread Lib/test/test_itertools.py Outdated
import warnings

def pickle_deprecated(testfunc):
""" Run the test twice. On the first pass, verify that a

@Yhg1s Yhg1s May 26, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth it to run them a third time, with DeprecationWarnings promoted to errors? That usually ends up exercising paths that rarely get considered, but it'd probably be more in pickle than in itertools.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rhettinger rhettinger May 26, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 26, 2023
rhettinger and others added 3 commits May 26, 2023 11:11
@rhettinger
Return NULL instead of None. Add third pass to check warning-to-error…
4fefb7e 
… promotion.
@rhettinger
Minor wording tweak
8943817
@rhettinger
Merge branch 'main' into itertool_pickle_deprecation
8b56c33
@rhettinger
rhettinger merged commit 402ee5a into python:main May 26, 2023
@miss-islington

miss-islington commented May 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
@rhettinger
rhettinger deleted the itertool_pickle_deprecation branch May 26, 2023 20:33
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@rhettinger @miss-islington
pythonGH-101588: Deprecate pickle/copy/deepcopy support in itertools (p…
e326b27 
…ythonGH-104965)

(cherry picked from commit 402ee5a)

Co-authored-by: Raymond Hettinger <[email protected]>
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104997 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023
rhettinger pushed a commit that referenced this pull request May 26, 2023
@miss-islington
[3.12] GH-101588: Deprecate pickle/copy/deepcopy support in itertools (…
05189f3 
…GH-104965) (GH-104997)
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rhettinger @miss-islington @bedevere-bot @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.