GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104984: remove kwargs and starargs from Call & ClassDef by Glyphack · Pull Request #104986 · python/cpython

Conversation

@Glyphack

@Glyphack Glyphack commented May 26, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These fields were removed in 025e9eb

Resolves: #104984

  • Issue: starargs and kwargs are removed from ClassDef and Call ast nodes #104984

📚 Documentation preview 📚: https://cpython-previews--104986.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Glyphack
pythongh-104984: remove kwargs and starargs from Call & ClassDef
63425dc 
These fields are removed in python@025e9eb
@bedevere-bot bedevere-bot added the awaiting review label May 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2023
starargs and kwargs are removed from ClassDef and Call ast nodes #104984
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 26, 2023
@ghost

ghost commented May 26, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm
carljm approved these changes May 26, 2023
View reviewed changes

@carljm carljm left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I verified that these arguments (and attributes) indeed don't exist anymore. Impressive that nobody noticed this until now in the 8(!) years since they were removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ghodsizadeh reacted with laugh emoji
All reactions
  • 😄 1 reaction
Comment thread Doc/library/ast.rst


.. class:: ClassDef(name, bases, keywords, starargs, kwargs, body, decorator_list)
.. class:: ClassDef(name, bases, keywords, body, decorator_list)

@carljm carljm May 26, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also now out of date with the implementation in main and 3.12 due to the addition of type_params argument in PEP 695, but that's being addressed in #104642

Still seems sensible to remove starargs and kwargs in this PR, and let @JelleZijlstra resolve the resulting conflict on this line in #104642

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@carljm carljm May 26, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, backporting this will mean that the PEP 695 docs PR won't backport cleanly, which may cause a bit more of a pain. @JelleZijlstra how do you prefer to handle this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 26, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merge this first, I'll take care of the backports

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 26, 2023
@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 26, 2023
@carljm
carljm merged commit 61c1d67 into python:main May 26, 2023
@miss-islington

miss-islington commented May 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @Glyphack for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@Glyphack @miss-islington
pythongh-104984: remove kwargs and starargs from Call & ClassDef (pyt…
687be76 
…honGH-104986)

These fields are removed in python@025e9eb
(cherry picked from commit 61c1d67)

Co-authored-by: Shaygan Hooshyari <[email protected]>
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104987 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104988 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@Glyphack @miss-islington
pythongh-104984: remove kwargs and starargs from Call & ClassDef (pyt…
a3d3111 
…honGH-104986)

These fields are removed in python@025e9eb
(cherry picked from commit 61c1d67)

Co-authored-by: Shaygan Hooshyari <[email protected]>
carljm pushed a commit that referenced this pull request May 26, 2023
@miss-islington @Glyphack
[3.12] gh-104984: remove kwargs and starargs from Call & ClassDef (GH…
bb1e57e 
…-104986) (#104987)

gh-104984: remove kwargs and starargs from Call & ClassDef (GH-104986)

These fields are removed in 025e9eb
(cherry picked from commit 61c1d67)

Co-authored-by: Shaygan Hooshyari <[email protected]>
AlexWaygood pushed a commit that referenced this pull request May 26, 2023
@miss-islington @Glyphack
[3.11] gh-104984: remove kwargs and starargs from Call & ClassDef (GH…
a632697 
…-104986) (#104988)

gh-104984: remove kwargs and starargs from Call & ClassDef (GH-104986)

These fields are removed in 025e9eb
(cherry picked from commit 61c1d67)

Co-authored-by: Shaygan Hooshyari <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

starargs and kwargs are removed from ClassDef and Call ast nodes

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Glyphack @miss-islington @bedevere-bot @carljm @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.