GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-104839: Prevent test_venv AddressSanitizer spam (GH-105005) by miss-islington · Pull Request #105006 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Pass any ASAN_OPTIONS environment variable through to the child process
so that leak sanitizer being disabled on our CI and buildbots stays
true in the children.
(cherry picked from commit a17f160)

Co-authored-by: Gregory P. Smith [email protected]

  • Issue: test_venv spams our AddressSanitizer CI with 5mb of test logs #104839

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gpshead @miss-islington
pythongh-104839: Prevent test_venv AddressSanitizer spam (pythonGH-10…
0e38b6c
…5005)

Pass any ASAN_OPTIONS environment variable through to the child process
so that leak sanitizer being disabled on our CI and buildbots stays
true in the children.
(cherry picked from commit a17f160)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington
miss-islington requested a review from vsajip as a code owner May 27, 2023 01:15
@bedevere-bot bedevere-bot added the awaiting review label May 27, 2023
This was referenced May 27, 2023
test_venv spams our AddressSanitizer CI with 5mb of test logs #104839
Closed
gh-104839: Prevent test_venv AddressSanitizer spam #105005
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels May 27, 2023
@gpshead
gpshead enabled auto-merge (squash) May 27, 2023 01:16
@gpshead gpshead self-assigned this May 27, 2023
@gpshead
gpshead merged commit f625ec3 into python:3.12 May 27, 2023
@bedevere-bot bedevere-bot removed the awaiting review label May 27, 2023
@miss-islington
miss-islington deleted the backport-a17f160-3.12 branch May 27, 2023 01:41
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.