GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104839: Prevent test_venv AddressSanitizer spam by gpshead · Pull Request #105005 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented May 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children.

Fixes #104839.

  • Issue: test_venv spams our AddressSanitizer CI with 5mb of test logs #104839

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
pythongh-104839: Prevent test_venv AddressSanitizer spam
29389b8 
Pass any ASAN_OPTIONS environment variable through to the child process
so that leak sanitizer being disabled on our CI and buildbots stays
true in the children.
@gpshead gpshead added tests Tests in the Lib/test dir skip news needs backport to 3.10 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 26, 2023
@gpshead
gpshead requested a review from vsajip as a code owner May 26, 2023 23:43
@bedevere-bot bedevere-bot added the awaiting core review label May 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 26, 2023
test_venv spams our AddressSanitizer CI with 5mb of test logs #104839
Closed
@gpshead

gpshead commented May 27, 2023

Copy link
Copy Markdown
Member Author

Only 596 lines of output in the Address Sanitizer Tests CI run. Yay, normal. No longer 50,000 and 5MiB.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
gpshead merged commit a17f160 into python:main May 27, 2023
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 27, 2023
@gpshead
gpshead deleted the test_venv_asan branch May 27, 2023 01:15
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @gpshead, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a17f160376955d369c8d332e1b1a90a6e18c852a 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned gpshead May 27, 2023
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Sorry @gpshead, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a17f160376955d369c8d332e1b1a90a6e18c852a 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@gpshead @miss-islington
pythongh-104839: Prevent test_venv AddressSanitizer spam (pythonGH-10…
0e38b6c 
…5005)

Pass any ASAN_OPTIONS environment variable through to the child process
so that leak sanitizer being disabled on our CI and buildbots stays
true in the children.
(cherry picked from commit a17f160)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105006 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
@gpshead gpshead removed needs backport to 3.10 needs backport to 3.11 only security fixes labels May 27, 2023
gpshead added a commit that referenced this pull request May 27, 2023
@miss-islington @gpshead
[3.12] gh-104839: Prevent test_venv AddressSanitizer spam (GH-105005) (…
f625ec3 
…#105006)

gh-104839: Prevent test_venv AddressSanitizer spam (GH-105005)

Pass any ASAN_OPTIONS environment variable through to the child process
so that leak sanitizer being disabled on our CI and buildbots stays
true in the children.
(cherry picked from commit a17f160)

Co-authored-by: Gregory P. Smith [Google] <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_venv spams our AddressSanitizer CI with 5mb of test logs

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gpshead @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.