GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: Precompute hash for config cache key in check_source job by itamaro · Pull Request #105008 · python/cpython

Conversation

@itamaro

@itamaro itamaro commented May 27, 2023

Copy link
Copy Markdown
Contributor

Followup to gh-104800, since all the build jobs already depend on the check_source job, we can precompute the hash in that job and reuse it in the downstream jobs.

While the time saving is negligible, the main benefit of this change is that the list of hashed files is not repeated in multiple places.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@itamaro
CI: Precompute hash for config cache key in check_source job
ae4465a
@itamaro
itamaro requested review from ezio-melotti and hugovk as code owners May 27, 2023 01:31
@bedevere-bot bedevere-bot added the awaiting review label May 27, 2023
@itamaro itamaro mentioned this pull request May 27, 2023
CI: Cache config.cache across runs to speed up build #104800
Merged
@arhadthedev arhadthedev added skip issue skip news labels May 27, 2023
hugovk
hugovk approved these changes May 27, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 27, 2023
@hugovk
hugovk merged commit 949f0f5 into python:main May 27, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 27, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 27, 2023
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @itamaro and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Sorry @itamaro and @hugovk, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hugovk May 27, 2023
@hugovk

hugovk commented May 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@itamaro Please could you backport these to 3.12 and 3.11?
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels May 27, 2023
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @itamaro for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105014 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@itamaro @miss-islington
CI: Precompute hash for config cache key in check_source job (pythonG…
a6c1b67 
…H-105008)

(cherry picked from commit 949f0f5)

Co-authored-by: Itamar Ostricher <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
@hugovk hugovk mentioned this pull request May 27, 2023
RtD docs previews: Cancel building PRs if no changes in Doc dir #104100
Merged
hugovk pushed a commit that referenced this pull request May 27, 2023
@miss-islington @itamaro
[3.12] CI: Precompute hash for config cache key in check_source job (G…
edd0cb8 
…H-105008) (#105014)

Co-authored-by: Itamar Ostricher <[email protected]>
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105024 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 27, 2023
@itamaro itamaro mentioned this pull request May 27, 2023
[3.11] CI: Precompute hash for config cache key in check_source job (GH-105008) #105024
Merged
itamaro added a commit to itamaro/cpython that referenced this pull request May 27, 2023
@itamaro
[3.11] CI: Precompute hash for config cache key in check_source job (p…
40532b0 
…ythonGH-105008)

Backport of pythongh-105014 to 3.11

(manually cherry picked from commit 949f0f5)
hugovk pushed a commit that referenced this pull request May 27, 2023
@itamaro
[3.11] CI: Precompute hash for config cache key in check_source job (G…
d1a7d66 
…H-105008) (#105024)
@erlend-aasland

erlend-aasland commented May 29, 2023

Copy link
Copy Markdown
Contributor

Nice; thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@itamaro
itamaro deleted the precompute-config-hash branch April 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@itamaro @miss-islington @hugovk @bedevere-bot @erlend-aasland @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.