GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105017: Fix including additional NL token when using CRLF by mgmacias95 · Pull Request #105022 · python/cpython

Conversation

@mgmacias95

@mgmacias95 mgmacias95 commented May 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Tokenizer produces different output on Windows on py312 for ends of files #105017

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mgmacias95
fix(tokenizer): Additional NL token when using CRLF
b0f5b4c
@mgmacias95
mgmacias95 requested review from lysnikolaou and pablogsal as code owners May 27, 2023 16:18
@bedevere-bot bedevere-bot added the awaiting review label May 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 27, 2023
Tokenizer produces different output on Windows on py312 for ends of files #105017
Closed
@blurb-it
📜🤖 Added by blurb_it.
b5510ab
pablogsal
pablogsal reviewed May 27, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-05-27-16-23-16.gh-issue-105017.KQrsC0.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update Misc/NEWS.d/next/Core and Builtins/2023-05-27-16-23-16.gh-issu…
c58df91 
…e-105017.KQrsC0.rst
pablogsal
pablogsal reviewed May 27, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-05-27-16-23-16.gh-issue-105017.KQrsC0.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update Misc/NEWS.d/next/Core and Builtins/2023-05-27-16-23-16.gh-issu…
2f7fe53 
…e-105017.KQrsC0.rst
pablogsal
pablogsal approved these changes May 27, 2023
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work ✨

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 27, 2023
@pablogsal pablogsal added needs backport to 3.12 only security fixes and removed awaiting merge labels May 27, 2023
@pablogsal
pablogsal enabled auto-merge (squash) May 27, 2023 16:26
@pablogsal
pablogsal merged commit 86d8f48 into python:main May 27, 2023
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @mgmacias95 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105023 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@mgmacias95 @pablogsal @miss-islington
pythongh-105017: Fix including additional NL token when using CRLF (p…
1c7e37d 
…ythonGH-105022)

(cherry picked from commit 86d8f48)

Co-authored-by: Marta Gómez Macías <[email protected]>
Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
pablogsal added a commit that referenced this pull request May 27, 2023
@miss-islington @mgmacias95 @pablogsal
[3.12] gh-105017: Fix including additional NL token when using CRLF (G…
2b176bc 
…H-105022) (#105023)

Co-authored-by: Marta Gómez Macías <[email protected]>
Co-authored-by: Pablo Galindo Salgado <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mgmacias95 @miss-islington @bedevere-bot @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.