GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104882: Docs: fix description of relationship between `socket.getblocking()` and `socket.gettimeout()` by joegeisbauer-ce · Pull Request #105026 · python/cpython

Conversation

@joegeisbauer-ce

@joegeisbauer-ce joegeisbauer-ce commented May 27, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
  • Issue: socket.getblocking() documentation lists opposite equivalence #104882

📚 Documentation preview 📚: https://cpython-previews--105026.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
joegeisbauer added 2 commits May 27, 2023 13:09
@joegeisbauer
docs: Fixed typo in socket.getblocking() docs
4a9b7ad 
- Change so that docs properly equate this with socket.gettimeout() != 0.
@joegeisbauer
docs: Added Misc/NEWS.d for updated documentation.
7ecd0cc 
WIP: temp commit
@bedevere-bot bedevere-bot added the awaiting review label May 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 27, 2023
socket.getblocking() documentation lists opposite equivalence #104882
Closed
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 27, 2023
@ghost

ghost commented May 27, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joegeisbauer-ce

joegeisbauer-ce commented May 27, 2023

Copy link
Copy Markdown
Author

This issue with the documentation goes back to v3.7.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 27, 2023
@joegeisbauer-ce

joegeisbauer-ce commented Jun 3, 2023

Copy link
Copy Markdown
Author

Will this automatically get marked for review or do I need to do anything special here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood
AlexWaygood approved these changes Jun 4, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 4, 2023
@AlexWaygood AlexWaygood added the skip news label Jun 4, 2023
@AlexWaygood
Delete unnecessary NEWS entry
ea618b0
@AlexWaygood AlexWaygood self-assigned this Jun 4, 2023
@AlexWaygood AlexWaygood changed the title gh-104882: Updated socket documentation for relationship between socket.getblocking() and socket.gettimeout(). gh-104882: Docs: fix description of relationship between socket.getblocking() and socket.gettimeout() Jun 4, 2023
@AlexWaygood
AlexWaygood merged commit 5a5ed7a into python:main Jun 4, 2023
@miss-islington

miss-islington commented Jun 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @joegeisbauer for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2023
@joegeisbauer @miss-islington
pythongh-104882: Docs: fix description of relationship between `socke…
181e0ca 
…t.getblocking()` and `socket.gettimeout()` (pythonGH-105026)

(cherry picked from commit 5a5ed7a)

Co-authored-by: Joe Geisbauer <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 4, 2023

Copy link
Copy Markdown

GH-105283 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 4, 2023
@bedevere-bot

bedevere-bot commented Jun 4, 2023

Copy link
Copy Markdown

GH-105284 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2023
@joegeisbauer @miss-islington
pythongh-104882: Docs: fix description of relationship between `socke…
e885bad 
…t.getblocking()` and `socket.gettimeout()` (pythonGH-105026)

(cherry picked from commit 5a5ed7a)

Co-authored-by: Joe Geisbauer <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Jun 4, 2023
@miss-islington @joegeisbauer
[3.12] gh-104882: Docs: fix description of relationship between `sock…
9ce3312 
…et.getblocking()` and `socket.gettimeout()` (GH-105026) (#105283)

gh-104882: Docs: fix description of relationship between `socket.getblocking()` and `socket.gettimeout()` (GH-105026)
(cherry picked from commit 5a5ed7a)

Co-authored-by: Joe Geisbauer <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Jun 4, 2023
@miss-islington @joegeisbauer
[3.11] gh-104882: Docs: fix description of relationship between `sock…
86eab08 
…et.getblocking()` and `socket.gettimeout()` (GH-105026) (#105284)

gh-104882: Docs: fix description of relationship between `socket.getblocking()` and `socket.gettimeout()` (GH-105026)
(cherry picked from commit 5a5ed7a)

Co-authored-by: Joe Geisbauer <[email protected]>
@AlexWaygood

AlexWaygood commented Jun 4, 2023

Copy link
Copy Markdown
Member

Thanks @joegeisbauer! I've merged the PR, and backported it to 3.12 and 3.11. Earlier versions of Python now only accept patches if they relate to security issues (which this isn't!), so it won't be backported to 3.10 or earlier.

I removed the NEWS entry before merging, as we don't usually include them for docs-only changes :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joegeisbauer-ce
joegeisbauer-ce deleted the fix-issue-104882 branch June 4, 2023 17:02
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joegeisbauer-ce @miss-islington @bedevere-bot @AlexWaygood @arhadthedev @joegeisbauer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.