GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER define by gpshead · Pull Request #10503 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Nov 13, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P

https://bugs.python.org/issue35214

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def.
567e981 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
@gpshead gpshead added needs backport to 3.6 skip news labels Nov 13, 2018
@gpshead gpshead self-assigned this Nov 13, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 13, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Nov 13, 2018
@gpshead
gpshead merged commit 3015fb8 into python:master Nov 13, 2018
@miss-islington

miss-islington commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 13, 2018
@gpshead
gpshead deleted the msan_Py_prefix branch November 13, 2018 06:01
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Nov 13, 2018
@bedevere-bot

bedevere-bot commented Nov 13, 2018

Copy link
Copy Markdown

GH-10504 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2018
@gpshead @miss-islington
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (pythonGH-10503)
9daeb64 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 13, 2018

Copy link
Copy Markdown

GH-10505 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Nov 13, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2018
@gpshead @miss-islington
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (pythonGH-10503)
150c4f9 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Nov 13, 2018
@miss-islington @gpshead
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503)
f6602f9 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Nov 13, 2018
@miss-islington @gpshead
bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503)
60cf265 
Rename our new MEMORY_SANITIZER define to _Py_MEMORY_SANITIZER.
Project based C Preprocessor namespacing at its finest. :P
(cherry picked from commit 3015fb8)

Co-authored-by: Gregory P. Smith <[email protected]>
@gpshead gpshead mentioned this pull request Aug 22, 2023
Get the test suite passing with clang Memory Sanitizer enabled #79395
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gpshead @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.