GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-89455: Add missing attributes (added in 3.11) to traceback module docs by Jackenmen · Pull Request #105044 · python/cpython

Conversation

@Jackenmen

@Jackenmen Jackenmen commented May 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It seems that exceptions have been missed when the exception groups were added in 3.11.

There are also two new parameters to TracebackException(...) - max_group_depth and max_group_width. I have only added the documentation for the parameters, not the attributes as modifying the latter wouldn't propagate the value to chained/grouped TracebackExceptions but I can add them if you wish.

I reused the issue number of the original issue that added these parameters/attributes.

I'm sorry for accidentally pinging so many people on #105043, GitHub doesn't warn you about the possibility of pinging people when changing the base :(
image

📚 Documentation preview 📚: https://cpython-previews--105044.org.readthedocs.build/

  • Issue: Implement PEP 654: Exception Groups #89455

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jackenmen added 4 commits May 28, 2023 21:00
@Jackenmen
Add missing 3.10/11 attributes to traceback module docs
2151f11
@Jackenmen
Add versionadded
67634c6
@Jackenmen
Update traceback.py
061cb4e
@Jackenmen
Add max_group_width/depth
4221618
@Jackenmen
Jackenmen requested a review from iritkatriel as a code owner May 28, 2023 19:03
@bedevere-bot bedevere-bot added the awaiting review label May 28, 2023
blurb-it Bot and others added 3 commits May 28, 2023 19:08
@blurb-it
📜🤖 Added by blurb_it.
b0ad19d
@blurb-it
📜🤖 Added by blurb_it.
0ddcd6f
@Jackenmen
Fix single backticks
4113e89
iritkatriel
iritkatriel reviewed May 28, 2023
View reviewed changes
Comment thread Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented May 28, 2023

Copy link
Copy Markdown
Member

I haven't created an issue for this because I figured it's just a documentation fix but I can create one if necessary.

We do create issues for documentation changes as well (unless trivial, as in typo).
In this case you could potentially attach this PR to the issue that added the fields you are documenting.
Jackenmen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Jackenmen and others added 2 commits May 28, 2023 23:03
@Jackenmen
Remove 3.10 changes
d749737
@Jackenmen @iritkatriel
Apply suggestions from code review
a9b7860 
Co-authored-by: Irit Katriel <[email protected]>
@Jackenmen Jackenmen changed the title Add missing 3.10/11 attributes to traceback module docs GH-89455: Add missing 3.11 attributes to traceback module docs May 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 28, 2023
Implement PEP 654: Exception Groups #89455
Closed
iritkatriel
iritkatriel reviewed May 28, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Documentation/2023-05-28-21-00-05.gh-issue-89455.j4cg7J.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added docs Documentation in the Doc dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 28, 2023
@Jackenmen
Wrap docs to 80 chars
1e04985
@iritkatriel iritkatriel changed the title GH-89455: Add missing 3.11 attributes to traceback module docs GH-89455: Add missing attributes (added in 3.11) to traceback module docs May 29, 2023
@Jackenmen
Merge changelog entries
a9c91c7
@Jackenmen

Jackenmen commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

Subinterpreters got hit by property-based tests, gonna retrigger the run
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Jackenmen
Merge branch 'main' into patch-1
0cfa80d
iritkatriel
iritkatriel approved these changes May 29, 2023
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few more minor suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Documentation/2023-05-28-21-01-00.gh-issue-89455.qAKRrA.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 29, 2023
@Jackenmen @iritkatriel
Apply suggestions from code review
848ad94 
Co-authored-by: Irit Katriel <[email protected]>
@iritkatriel
iritkatriel enabled auto-merge (squash) May 29, 2023 18:13
@iritkatriel
iritkatriel merged commit 39f6a04 into python:main May 29, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 29, 2023
@miss-islington

miss-islington commented May 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @Jackenmen for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

GH-105066 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 29, 2023
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

GH-105067 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2023
@Jackenmen @miss-islington
pythonGH-89455: Add missing attributes (added in 3.11) to traceback m…
0091b39 
…odule docs (pythonGH-105044)

(cherry picked from commit 39f6a04)

Co-authored-by: Jakub Kuczys <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 29, 2023
@Jackenmen
Jackenmen deleted the patch-1 branch May 29, 2023 18:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2023
@Jackenmen @miss-islington
pythonGH-89455: Add missing attributes (added in 3.11) to traceback m…
a33343f 
…odule docs (pythonGH-105044)

(cherry picked from commit 39f6a04)

Co-authored-by: Jakub Kuczys <[email protected]>
iritkatriel pushed a commit that referenced this pull request May 29, 2023
@miss-islington @Jackenmen
[3.12] GH-89455: Add missing attributes (added in 3.11) to traceback …
6794526 
…module docs (GH-105044) (#105066)

GH-89455: Add missing attributes (added in 3.11) to traceback module docs (GH-105044)
(cherry picked from commit 39f6a04)

Co-authored-by: Jakub Kuczys <[email protected]>
iritkatriel pushed a commit that referenced this pull request May 29, 2023
@miss-islington @Jackenmen
[3.11] GH-89455: Add missing attributes (added in 3.11) to traceback …
c39500d 
…module docs (GH-105044) (#105067)

GH-89455: Add missing attributes (added in 3.11) to traceback module docs (GH-105044)
(cherry picked from commit 39f6a04)

Co-authored-by: Jakub Kuczys <[email protected]>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Jackenmen @iritkatriel @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.