GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix compiler warning in unicodeobject.c by methane · Pull Request #105050 · python/cpython

Conversation

@methane

@methane methane commented May 29, 2023

Copy link
Copy Markdown
Member

Apple clang version 14.0.3 (clang-1403.0.22.14.1)

Objects/unicodeobject.c:239:24: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyUnicode_InternedSize()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
Fix warning in unicodeobject.c
bd54214
@methane methane added skip issue skip news labels May 29, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 29, 2023
@methane methane added 3.12 only security fixes 3.13 only security fixes needs backport to 3.12 only security fixes labels May 29, 2023
corona10
corona10 approved these changes May 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 29, 2023
@methane
methane merged commit e92ac0a into python:main May 29, 2023
@methane
methane deleted the fix-warning branch May 29, 2023 08:31
@miss-islington

miss-islington commented May 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 29, 2023
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

GH-105053 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 29, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2023
@methane @miss-islington
Fix compiler warning in unicodeobject.c (pythonGH-105050)
85c9d7d 
(cherry picked from commit e92ac0a)

Co-authored-by: Inada Naoki <[email protected]>
methane added a commit that referenced this pull request May 29, 2023
@miss-islington @methane
Fix compiler warning in unicodeobject.c (GH-105050)
5dc6b18 
Fix compiler warning in unicodeobject.c (GH-105050)
(cherry picked from commit e92ac0a)

Co-authored-by: Inada Naoki <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes 3.13 only security fixes skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@methane @miss-islington @bedevere-bot @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.