GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104922: Make `PY_SSIZE_T_CLEAN` not mandatory again by methane · Pull Request #105051 · python/cpython

Conversation

@methane

@methane methane commented May 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR makes APIs like PyArg_Parse() accepts # format specifier with ssize_t.
_SizeT variants APIs are now ABI-only if they are part of stable ABI.

  • Update docs
  • Add news entry.
  • Add what's new entry.
  • Issue: Make PY_SSIZE_T_CLEAN not mandatory again #104922

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane methane added the topic-C-API label May 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
Make PY_SSIZE_T_CLEAN not mandatory again #104922
Closed
@methane
methane force-pushed the always-ssize_t_clean branch from a33f859 to c5e2d8c Compare May 29, 2023 06:19
@methane

methane commented May 29, 2023

Copy link
Copy Markdown
Member Author

@vstinner I prefer this PR (PyArg_ParseTuple() now uses Py_ssize_t) over #104923 (PyArg_ParseTuple() keeps raising SystemError for '#' but always #define PyArg_ParseTuple _PyArg_ParseTuple_SizeT.

What do you think?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane added 4 commits May 30, 2023 21:53
@methane
Make PY_SSIZE_T_CLEAN always.
699f348
@methane
remove unused flags
111adaa
@methane
format
1a42a3f
@methane
Add NEWS
a0af3b5
@methane
methane force-pushed the always-ssize_t_clean branch from 954122c to a0af3b5 Compare May 30, 2023 12:54
@vstinner

vstinner commented May 30, 2023

Copy link
Copy Markdown
Member

What do you think?

I'm away from Python. You will have to find a different reviewer 😁
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane added 2 commits May 31, 2023 02:58
@methane
Update doc and add what's new entry
128960d
@methane
Remove news entry until CI workflow is fixed.
c5baa34
@methane

methane commented May 30, 2023

Copy link
Copy Markdown
Member Author

I removed NEWS entry because current CI workflow doesn't accept path including space.

#103914 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane
Remove uneeded test.
cb35202
@methane
methane force-pushed the always-ssize_t_clean branch from 238cd95 to cb35202 Compare May 31, 2023 01:07
methane added 3 commits May 31, 2023 10:15
@methane
Merge remote-tracking branch 'upstream/main' into always-ssize_t_clean
092cb30
@methane
Revert "Remove news entry until CI workflow is fixed."
db7770f 
This reverts commit c5baa34.
@methane
fix a warning
98245f0
@methane
methane marked this pull request as ready for review May 31, 2023 04:06
@methane
methane requested a review from markshannon as a code owner May 31, 2023 04:06
@bedevere-bot bedevere-bot added the awaiting core review label May 31, 2023
@methane
methane merged commit adccff3 into python:main May 31, 2023
@methane
methane deleted the always-ssize_t_clean branch May 31, 2023 09:38
@bedevere-bot bedevere-bot removed the awaiting core review label May 31, 2023
yselkowitz added a commit to yselkowitz/vim that referenced this pull request Jun 23, 2024
@yselkowitz
runtime(python): fix compatibility with Python 3.13
18839a1 
_PyObject_CallFunction_SizeT was dropped in Python 3.13:

python/cpython#105051

Signed-off-by: Yaakov Selkowitz <[email protected]>
@yselkowitz yselkowitz mentioned this pull request Jun 23, 2024
python: fix compatibility with Python 3.13 vim/vim#15088
Closed
chrisbra pushed a commit to vim/vim that referenced this pull request Jul 4, 2024
@yselkowitz @chrisbra
patch 9.1.0521: if_py: _PyObject_CallFunction_SizeT is dropped in Pyt…
4179f19 
…hon 3.13

Problem:  if_py: _PyObject_CallFunction_SizeT is dropped in Python 3.13
Solution: define PyObject_CallFunction for Python >= 3.13
          (Yaakov Selkowitz)

references: python/cpython#105051

closes: #15088

Signed-off-by: Yaakov Selkowitz <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
RestorerZ pushed a commit to RestorerZ/fork_vim-orig that referenced this pull request Jul 9, 2024
@yselkowitz @RestorerZ
patch 9.1.0521: if_py: _PyObject_CallFunction_SizeT is dropped in Pyt…
53b2e52 
…hon 3.13

Problem:  if_py: _PyObject_CallFunction_SizeT is dropped in Python 3.13
Solution: define PyObject_CallFunction for Python >= 3.13
          (Yaakov Selkowitz)

references: python/cpython#105051

closes: vim#15088

Signed-off-by: Yaakov Selkowitz <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@methane @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.