GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-88745: Add _winapi.CopyFile2 and update shutil.copy2 to use it by zooba · Pull Request #105055 · python/cpython

Conversation

@zooba

@zooba zooba commented May 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: shutil.copy() inefficient implementation in Windows #88745

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-88745: Add _winapi.CopyFile2 and update shutil.copy2 to use it
dffb615
@zooba zooba added performance Performance or resource usage OS-windows needs backport to 3.12 only security fixes labels May 29, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
shutil.copy() inefficient implementation in Windows #88745
Closed
@zooba
Update clinic again
5b8788d
@zooba

zooba commented May 29, 2023

Copy link
Copy Markdown
Member Author

The readthedocs check cancelled due to no doc changes, so all relevant checks passed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Remove dead code
76f379a
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit 76f379a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@zooba
Pythonize the names
f829448
@zooba
zooba merged commit cda1bd3 into python:main May 30, 2023
@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 30, 2023
@zooba
zooba deleted the gh-88745 branch May 30, 2023 10:00
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105086 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
@zooba @miss-islington
pythongh-88745: Add _winapi.CopyFile2 and update shutil.copy2 to use …
6edc59a 
…it (pythonGH-105055)

(cherry picked from commit cda1bd3)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
zooba added a commit that referenced this pull request May 30, 2023
@miss-islington @zooba
gh-88745: Add _winapi.CopyFile2 and update shutil.copy2 to use it (GH…
9ae49e3 
…-105055)

(cherry picked from commit cda1bd3)

Co-authored-by: Steve Dower <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@NewUserHa NewUserHa mentioned this pull request Dec 8, 2025
Update shutil.rst to clarify copy performance on Windows #142407
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.