GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105042: Disable unmatched parens syntax error in python tokenize by lysnikolaou · Pull Request #105061 · python/cpython

Conversation

@lysnikolaou

@lysnikolaou lysnikolaou commented May 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: SyntaxError: unmatched ')' with whitespace in lambda? #105042

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lysnikolaou
pythongh-105042: Disable unmatched parens syntax error in python toke…
1c38078 
…nize
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
SyntaxError: unmatched ')' with whitespace in lambda? #105042
Closed
pablogsal
pablogsal reviewed May 30, 2023
View reviewed changes
Comment thread Python/Python-tokenize.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 30, 2023

Copy link
Copy Markdown
Member

We also need a bunch of tests that cover these, one in the inspect module and the other in the tokenize module
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed May 30, 2023
View reviewed changes
Comment thread Lib/tokenize.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed May 30, 2023
View reviewed changes
Comment thread Parser/tokenizer.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou
Reuse flag and allow f-string check
ed1237a
@lysnikolaou
lysnikolaou force-pushed the tokenize-unmatched-parens branch from 049da25 to ed1237a Compare May 30, 2023 09:55
@lysnikolaou
lysnikolaou marked this pull request as ready for review May 30, 2023 09:56
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
@lysnikolaou lysnikolaou added the skip news label May 30, 2023
@lysnikolaou

lysnikolaou commented May 30, 2023

Copy link
Copy Markdown
Member Author

@pablogsal This is ready for another review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 30, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We also need a bunch of tests that cover these, one in the inspect module and the other in the tokenize module

Can you add a couple of tests for this?

Maybe something on these lines: #105042 (comment) in the inspect module here:

cpython/Lib/test/test_inspect.py

Line 779 in 0656d23

def test_parenthesized_multiline_lambda(self):

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lysnikolaou
Add tests
c7481a5
@lysnikolaou

lysnikolaou commented May 30, 2023

Copy link
Copy Markdown
Member Author

@pablogsal Thanks for the reminder! Tests added in c7481a5.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes May 30, 2023
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fantastic work!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2023
@pablogsal pablogsal added the needs backport to 3.12 only security fixes label May 30, 2023
@pablogsal
pablogsal merged commit 70f315c into python:main May 30, 2023
@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
@lysnikolaou @miss-islington
pythongh-105042: Disable unmatched parens syntax error in python toke…
bb899c1 
…nize (pythonGH-105061)

(cherry picked from commit 70f315c)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105120 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
pablogsal pushed a commit that referenced this pull request May 31, 2023
@miss-islington @lysnikolaou
[3.12] gh-105042: Disable unmatched parens syntax error in python tok…
2f8c22f 
…enize (GH-105061) (#105120)

gh-105042: Disable unmatched parens syntax error in python tokenize (GH-105061)
(cherry picked from commit 70f315c)

Co-authored-by: Lysandros Nikolaou <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@asottile asottile mentioned this pull request Jun 13, 2023
3.12+: TokenError no longer raised for some invalid source (mismatched braces?) #105714
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lysnikolaou @pablogsal @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.