GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103646: Remove --include-pip-user from default APPX package build by zooba · Pull Request #105064 · python/cpython

Conversation

@zooba

@zooba zooba commented May 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Windows Store installation of Python adds a pip.ini file which configures --user #103646

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-103646: Remove --include-pip-user from default APPX package …
c00bfe9 
…build
@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.12 only security fixes labels May 29, 2023
@zooba
zooba requested a review from a team as a code owner May 29, 2023 16:10
@bedevere-bot bedevere-bot added the awaiting core review label May 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
Windows Store installation of Python adds a pip.ini file which configures --user #103646
Closed
pfmoore
pfmoore reviewed May 29, 2023
View reviewed changes

@pfmoore pfmoore left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to completely remove the "pip-user" option? As far as I can see, it's only used in get_pip_layout in PC\layout\support\pip.py. Having the option present but never used seems like a potential source of confusion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba

zooba commented May 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Deprecating and removing a command line option is a bigger change than just changing a preset, since the presets are deliberately unspecified.

I doubt anyone is actually using it, but I see no reason to find out by simply removing it. There are potentially useful scenarios that might be using it where they wouldn't be covered by the unwritable-Lib fallback (I know of one such scenario, though I don't know that they're actively using this option).
pfmoore reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 6da7015 into python:main May 29, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 29, 2023
@miss-islington

miss-islington commented May 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2023
@zooba @miss-islington
pythongh-103646: Remove --include-pip-user from default APPX package …
d93d7e5 
…build (pythonGH-105064)

(cherry picked from commit 6da7015)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

GH-105065 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 29, 2023
@zooba

zooba commented May 29, 2023

Copy link
Copy Markdown
Member Author

Want to make sure this is in for 3.12.0b2 tomorrow, but we can look at cleaning up unused options later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba deleted the gh-103646 branch May 29, 2023 16:58
zooba added a commit that referenced this pull request May 29, 2023
@miss-islington @zooba
gh-103646: Remove --include-pip-user from default APPX package build (G…
56722ef 
…H-105064)

(cherry picked from commit 6da7015)

Co-authored-by: Steve Dower <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfmoore pfmoore pfmoore left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @miss-islington @bedevere-bot @pfmoore
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.