GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105077: Fix test_tkinter refleak checking by zware · Pull Request #105078 · python/cpython

Conversation

@zware

@zware zware commented May 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use specific symbols from test.support to avoid having support
overwritten by test_tkinter's own support submodule.

  • Issue: test_tkinter fails on refleak run due to support confusion #105077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
pythongh-105077: Fix test_tkinter refleak checking
b807168 
Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
@zware zware added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir skip news topic-tkinter labels May 30, 2023
@zware zware self-assigned this May 30, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
test_tkinter fails on refleak run due to support confusion #105077
Closed
@zware
zware enabled auto-merge (squash) May 30, 2023 03:27
@zware zware added the needs backport to 3.12 only security fixes label May 30, 2023
JelleZijlstra
JelleZijlstra approved these changes May 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2023
@zware
zware merged commit 5454db4 into python:main May 30, 2023
@zware
zware deleted the fix_test_tkinter_refleak_checking branch May 30, 2023 03:53
@bedevere-bot bedevere-bot removed the awaiting merge label May 30, 2023
@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2023
@zware @miss-islington
pythongh-105077: Fix test_tkinter refleak checking (pythonGH-105078)
55edff7 
Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
(cherry picked from commit 5454db4)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105079 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
zware pushed a commit that referenced this pull request May 30, 2023
@miss-islington
[3.12] gh-105077: Fix test_tkinter refleak checking (GH-105078) (GH-1…
7f04a15 
…05079)

Use specific symbols from `test.support` to avoid having `support`
overwritten by `test_tkinter`'s own `support` submodule.
(cherry picked from commit 5454db4)
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zware zware

Labels

skip news tests Tests in the Lib/test dir topic-tkinter type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zware @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.