GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-102251: Fix reference leak in _testsinglephase initialization by sunmy2019 · Pull Request #105082 · python/cpython

Conversation

sunmy2019 commented May 30, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Fix Refleak in test_import #102251

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          add missing decref in testsinglephase

dfd70c5

sunmy2019 requested review from ericsnowcurrently and erlend-aasland

May 30, 2023 08:58

bedevere-bot added the awaiting review label

May 30, 2023

bedevere-bot mentioned this pull request

May 30, 2023

Fix Refleak in test_import #102251

Closed

sunmy2019 added the skip news label

May 30, 2023

erlend-aasland reviewed

May 30, 2023

View reviewed changes

Comment thread

Modules/_testsinglephase.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

sunmy2019 mentioned this pull request

May 30, 2023

gh-102251: add missing cleanups for test_import #104796

Closed


          Use idiomatic C code

587533c

erlend-aasland approved these changes

May 30, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

May 30, 2023

erlend-aasland self-assigned this

May 30, 2023

erlend-aasland added the needs backport to 3.12 only security fixes label

May 30, 2023

erlend-aasland enabled auto-merge (squash)

May 30, 2023 09:05

erlend-aasland changed the title ~~gh-102251: add missing decref in testsinglephase~~ gh-102251: Fix reference leak in _testsinglephase initialization

May 30, 2023

erlend-aasland commented May 30, 2023

Copy link

Copy Markdown

Contributor

Thanks

sunmy2019 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland merged commit d14eb34 into python:main

May 30, 2023

miss-islington commented May 30, 2023

Copy link

Copy Markdown

Contributor

Thanks @sunmy2019 for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

May 30, 2023

bedevere-bot commented May 30, 2023

Copy link

Copy Markdown

GH-105083 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

May 30, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 30, 2023


          pythongh-102251: Fix reference leak in _testsinglephase initialization (

7924bd6

pythonGH-105082)

Correctly decref 'initialized' in init_module()

(cherry picked from commit d14eb34)

Co-authored-by: sunmy2019 <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>

sunmy2019 deleted the gh-102251-1 branch

May 30, 2023 09:36

erlend-aasland added a commit that referenced this pull request

May 30, 2023


          [3.12] gh-102251: Fix reference leak in _testsinglephase initializati…

fd6b913

…on (GH-105082) (#105083)

Correctly decref 'initialized' in init_module()

(cherry picked from commit d14eb34)

Co-authored-by: sunmy2019 <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>

erlend-aasland mentioned this pull request

Jun 6, 2023

3.12 backport gh 105236 #105358

Closed

Reviewers

erlend-aasland

erlend-aasland approved these changes

ericsnowcurrently

Awaiting requested review from ericsnowcurrently

ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sunmy2019 commented May 30, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented May 30, 2023

Uh oh!

miss-islington commented May 30, 2023

Uh oh!

bedevere-bot commented May 30, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sunmy2019 commented May 30, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.