GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-105102: fix nested unions in structures when the system byteorder is the opposite by Sh3idan · Pull Request #105106 · python/cpython

Conversation

Sh3idan commented May 30, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: #105102

Issue: TypeError when using ctypes.BigEndianUnion nested in ctypes.BigEndianStructure on a little endian system (or vice versa) #105102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix nested unions in structures in the opposite system byteorder

7d04cb3

bedevere-bot added the awaiting review label

May 30, 2023

bedevere-bot mentioned this pull request

May 30, 2023

TypeError when using ctypes.BigEndianUnion nested in ctypes.BigEndianStructure on a little endian system (or vice versa) #105102

Closed

Sh3idan and others added 5 commits

May 30, 2023 19:13


          trim trailing whitespace

9fe1324


          trim trailing whitespace

28497bc


          Merge branch 'main' into fix-pythongh-105102

96735a3


          Merge branch 'main' into fix-pythongh-105102

3165db1


          Update _endian.py

00cb70b

serhiy-storchaka approved these changes

Jan 17, 2024

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jan 17, 2024

serhiy-storchaka approved these changes

Jan 17, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka enabled auto-merge (squash)

January 17, 2024 18:03

serhiy-storchaka added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jan 17, 2024

serhiy-storchaka merged commit 0b541f6 into python:main

Jan 17, 2024

miss-islington-app Bot commented Jan 17, 2024

Copy link

Copy Markdown

Thanks @Sh3idan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jan 17, 2024

miss-islington-app Bot commented Jan 17, 2024

Copy link

Copy Markdown

Sorry, @Sh3idan and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0b541f64c472976b2fee1ec9919bc7b02a798242 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned serhiy-storchaka

Jan 17, 2024

miss-islington-app Bot commented Jan 17, 2024

Copy link

Copy Markdown

Sorry, @Sh3idan and @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0b541f64c472976b2fee1ec9919bc7b02a798242 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request

Jan 17, 2024


          [3.12] pythongh-105102: Fix nested unions in structures when the syst…

74fcab3

…em byteorder is the opposite (pythonGH-105106)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <[email protected]>

bedevere-app Bot commented Jan 17, 2024

Copy link

Copy Markdown

GH-114204 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Jan 17, 2024

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request

Jan 17, 2024


          [3.11] pythongh-105102: Fix nested unions in structures when the syst…

482a655

…em byteorder is the opposite (pythonGH-105106)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <[email protected]>

bedevere-app Bot commented Jan 17, 2024

Copy link

Copy Markdown

GH-114205 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Jan 17, 2024

serhiy-storchaka added a commit that referenced this pull request

Jan 17, 2024


          [3.11] gh-105102: Fix nested unions in structures when the system byt…

2b03259

…eorder is the opposite (GH-105106) (GH-114205)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <[email protected]>

serhiy-storchaka added a commit that referenced this pull request

Jan 17, 2024


          [3.12] gh-105102: Fix nested unions in structures when the system byt…

a735fea

…eorder is the opposite (GH-105106) (GH-114204)

(cherry picked from commit 0b541f6)

Co-authored-by: Sheidan <[email protected]>

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request

Jan 22, 2024


          pythongh-105102: Fix nested unions in structures when the system byte…

…order is the opposite (pythonGH-105106)

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-105102: Fix nested unions in structures when the system byte…

893ed6c

…order is the opposite (pythonGH-105106)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-105102: Fix nested unions in structures when the system byte…

d33081d

…order is the opposite (pythonGH-105106)

serhiy-storchaka removed their assignment

Jul 15, 2026

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Sh3idan commented May 30, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jan 17, 2024

Uh oh!

miss-islington-app Bot commented Jan 17, 2024

Uh oh!

miss-islington-app Bot commented Jan 17, 2024

Uh oh!

bedevere-app Bot commented Jan 17, 2024

Uh oh!

bedevere-app Bot commented Jan 17, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sh3idan commented May 30, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.