GeezerVison is showing github.com — gh-105107: Remove PyEval_CallFunction() function by vstinner · Pull Request #105108 · python/cpython
Conversation
vstinner
commented
May 30, 2023
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Remove 4 functions from the C API, deprecated in Python 3.9:
- PyEval_CallObjectWithKeywords()
- PyEval_CallObject()
- PyEval_CallFunction()
- PyEval_CallMethod()
Keep 3 functions in the stable ABI:
- PyEval_CallObjectWithKeywords()
- PyEval_CallFunction()
- PyEval_CallMethod()
📚 Documentation preview 📚: https://cpython-previews--105108.org.readthedocs.build/
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The "Tests / Check for source changes (pull_request)" CI job failed because the added NEWS entry filename contains a space in C API/ sub-directory name.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I've merged #105110 to workaround the CI error, let's update this branch.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Remove 4 functions from the C API, deprecated in Python 3.9:
* PyEval_CallObjectWithKeywords()
* PyEval_CallObject()
* PyEval_CallFunction()
* PyEval_CallMethod()
Keep 3 functions in the stable ABI:
* PyEval_CallObjectWithKeywords()
* PyEval_CallFunction()
* PyEval_CallMethod()
|
I completed the documentation how to port existing code after reading comments of the long issue #73734.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
I've merged #105110 to workaround the CI error, let's update this branch.
Thanks. To complete the doc, I rebased my PR on the main branch.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot ARM Raspbian 3.x has failed when building commit 579c41c.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/4108) and take a look at the build logs.
- Check if the failure is related to this commit (579c41c) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/all/#builders/424/builds/4108
Failed tests:
Failed subtests:
- test_interact_on_disk_file - test.test_sqlite3.test_cli.InteractiveSession.test_interact_on_disk_file
Summary of the results of the build (if available):
== Tests result: FAILURE then ENV CHANGED ==
427 tests OK.
10 slowest tests:
- test_venv: 10 min 28 sec
- test_tarfile: 9 min 43 sec
- test_largefile: 8 min 17 sec
- test_cmd_line_script: 5 min 29 sec
- test_math: 4 min 22 sec
- test_multiprocessing_spawn: 4 min 14 sec
- test_sqlite3: 3 min 30 sec
- test_exceptions: 3 min 23 sec
- test_concurrent_futures: 3 min 7 sec
- test_hashlib: 2 min 12 sec
1 test altered the execution environment:
test_concurrent_futures
19 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_idle
test_ioctl test_kqueue test_launcher test_perf_profiler
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64
1 re-run test:
test_sqlite3
Total duration: 41 min 25 sec
Click to see traceback logs
Traceback (most recent call last):
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_sqlite3/test_cli.py", line 142, in test_interact_on_disk_file
out, err = proc.communicate(input="create table t(t);",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/subprocess.py", line 1209, in communicate
stdout, stderr = self._communicate(input, endtime, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/subprocess.py", line 2109, in _communicate
self._check_timeout(endtime, orig_timeout, stdout, stderr)
File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/subprocess.py", line 1253, in _check_timeout
raise TimeoutExpired(
subprocess.TimeoutExpired: Command '['/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/python', '-Xutf8', '-m', 'sqlite3', '@test_21594_tmpæ']' timed out after 5.25 seconds
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
methane
methane approved these changes
markshannon
Awaiting requested review from markshannon
markshannon is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|