GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: Temporarily skip paths with spaces to avoid error by hugovk · Pull Request #105110 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 30, 2023

Copy link
Copy Markdown
Member

PRs like these:

  • gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except* implementation in the unstable API #105072
  • gh-105107: Remove PyEval_CallFunction() function #105108

Have NEWS files in subdirectories containing spaces:

  • Misc/NEWS.d/next/C API/2023-05-30-10-15-13.gh-issue-105071.dPtp7c.rst
  • Misc/NEWS.d/next/C API/2023-05-30-19-11-09.gh-issue-105107.YQwMnm.rst

But the https://github.com/Ana06/get-changed-files action (added in #103914) fails for such files with:

Error: One of your files includes a space. Consider using a different output format or removing spaces from your filenames. Please submit an issue on this action's GitHub repo.

We ran into this before and worked around it in #103019 by skipping Misc and its subdirs.

Let's do something similar here, by replacing Misc with a list of its subdirs that are absent a space.

See also python/core-workflow#186 to rename the C API and Core and Builtins directories to C-API and Core-and-Builtins to avoid this altogether.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk
CI: Temporarily skip paths with spaces to avoid "Error: One of your f…
ef110f9 
…iles includes a space"
@hugovk hugovk added skip issue skip news labels May 30, 2023
hugovk added 2 commits May 30, 2023 21:34
@hugovk
Dummy NEWS file to test the action. Will be deleted before merge.
05cd028
@hugovk
Revert "Dummy NEWS file to test the action. Will be deleted before me…
157a9b4 
…rge."

This reverts commit 05cd028.
@hugovk

hugovk commented May 30, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

✅ No error with a dummy file at Misc/NEWS.d/next/C API/2023-05-30-21-34-29.gh-issue-105107.1mmbfA.rst (05cd028):

Run Ana06/[email protected]
Base commit: 457[1](https://github.com/python/cpython/actions/runs/5125091879/jobs/9217804839#step:5:1)eedca2f70768ddc4a2fd4fba2ae11b4c8037
Head commit: 05cd028fd4c56e3173b134b10dc947c3af471d82
All: 
Added: 
Modified: 
Removed: 
Renamed: 
Added or modified: 
Added, modified or renamed:

https://github.com/python/cpython/actions/runs/5125091879/jobs/9217804839
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk marked this pull request as ready for review May 30, 2023 19:06
@hugovk
hugovk requested a review from ezio-melotti as a code owner May 30, 2023 19:06
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
@hugovk hugovk mentioned this pull request May 30, 2023
Convert doc.yml workflow to be reusable #103914
Merged
carljm
carljm approved these changes May 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2023
gpshead
gpshead approved these changes May 30, 2023
View reviewed changes
@hugovk
hugovk merged commit 4c77061 into python:main May 30, 2023
@hugovk
hugovk deleted the ci-workaround-path-spaces-error branch May 30, 2023 20:01
@bedevere-bot bedevere-bot removed the awaiting merge label May 30, 2023
@hugovk hugovk mentioned this pull request May 30, 2023
gh-105107: Remove PyEval_CallFunction() function #105108
Merged
carljm added a commit to carljm/cpython that referenced this pull request May 30, 2023
@carljm
Merge branch 'main' into superbadgetattro
24e1159 
* main:
  CI: Temporarily skip paths with spaces to avoid error (python#105110)
  pythongh-105071: add missing versionadded directive (python#105097)
  pythongh-80064: Fix is_valid_wide_char() return type (python#105099)
  Small speedup for dataclass __eq__ and __repr__ (python#104904)
  pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093)
  pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
@vstinner

vstinner commented May 31, 2023

Copy link
Copy Markdown
Member

But the https://github.com/Ana06/get-changed-files action (added in #103914) fails for such files with

Maybe you should report the bug there?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented May 31, 2023

Copy link
Copy Markdown
Member Author

It's a feature: https://github.com/Ana06/get-changed-files#usage says the default behaviour is to return files separated by spaces (format: 'space-delimited'), and will fail if any files contain spaces. They suggest using one of the other formats in such case (CSV, JSON).

(Let's continue discussion in #103914).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
webknjaz added a commit to webknjaz/cpython that referenced this pull request May 31, 2023
@webknjaz
Revert "CI: Temporarily skip paths with spaces to avoid error (python…
4b0020f 
…#105110)"

This reverts commit 4c77061.
@webknjaz

webknjaz commented May 31, 2023

Copy link
Copy Markdown
Member

@vstinner I've just submitted a proper fix: #105151
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk pushed a commit to hugovk/cpython that referenced this pull request Jun 1, 2023
@webknjaz @hugovk
Revert "CI: Temporarily skip paths with spaces to avoid error (python…
daadd19 
…#105110)"

This reverts commit 4c77061.
hugovk pushed a commit to hugovk/cpython that referenced this pull request Jun 1, 2023
@webknjaz @hugovk
Revert "CI: Temporarily skip paths with spaces to avoid error (python…
a96bfc5 
…#105110)"

This reverts commit 4c77061.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@gpshead gpshead gpshead approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hugovk @vstinner @webknjaz @carljm @gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.