GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105069: Add a readline-like callable to the tokenizer to consume input iteratively (GH-105070) by miss-islington · Pull Request #105119 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 9216e69)

Co-authored-by: Pablo Galindo Salgado [email protected]

  • Issue: Consider not consuming all the buffer in one go in the tokenizer module #105069

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bateller reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@pablogsal @miss-islington
pythongh-105069: Add a readline-like callable to the tokenizer to con…
6de88f2 
…sume input iteratively (pythonGH-105070)

(cherry picked from commit 9216e69)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners May 30, 2023 21:44
@bedevere-bot bedevere-bot added the awaiting review label May 30, 2023
This was referenced May 30, 2023
Consider not consuming all the buffer in one go in the tokenizer module #105069
Closed
gh-105069: Add a readline-like callable to the tokenizer to consume input iteratively #105070
Merged
@bedevere-bot bedevere-bot added the skip news label May 30, 2023
pablogsal
pablogsal approved these changes May 30, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 30, 2023
bateller
bateller approved these changes May 31, 2023
View reviewed changes

@bateller bateller left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal merged commit c687946 into python:3.12 May 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 31, 2023
@miss-islington
miss-islington deleted the backport-9216e69-3.12 branch May 31, 2023 10:12
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
+1 more reviewer
@bateller bateller bateller approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @bateller @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.