GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105096: Reformat wave documentation (#105136) by vstinner · Pull Request #105138 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 31, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add ".. class::" markups in the wave documentation.

  • Reformat also wave.py (minor PEP 8 changes).
  • Remove redundant "import struct": it's already imported at top level.
  • Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)

  • Issue: wave: Deprecate getmark(), setmark() and getmarkers() methods #105096

📚 Documentation preview 📚: https://cpython-previews--105138.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105096: Reformat wave documentation (python#105136)
f612e69 
Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)
@bedevere-bot bedevere-bot added the awaiting core review label May 31, 2023
This was referenced May 31, 2023
wave: Deprecate getmark(), setmark() and getmarkers() methods #105096
Closed
gh-105096: Reformat wave documentation #105136
Merged
@bedevere-bot bedevere-bot added the skip news label May 31, 2023
@vstinner vstinner added the needs backport to 3.11 only security fixes label May 31, 2023
@vstinner

vstinner commented May 31, 2023

Copy link
Copy Markdown
Member Author

Automated backport failed since "aifc module" was replaced with "old aifc module" in the main branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) May 31, 2023 11:43
@vstinner
vstinner merged commit 01b42f9 into python:3.12 May 31, 2023
@miss-islington

miss-islington commented May 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 31, 2023
@miss-islington

miss-islington commented May 31, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 01b42f9559b614d729c3f055d09269db13d2433c 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner May 31, 2023
@vstinner
vstinner deleted the wave_doc312 branch May 31, 2023 14:34
@bedevere-bot

bedevere-bot commented May 31, 2023

Copy link
Copy Markdown

GH-105155 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 31, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request May 31, 2023
@vstinner
[3.12] pythongh-105096: Reformat wave documentation (python#105136) (p…
6874b65 
…ython#105138)

pythongh-105096: Reformat wave documentation (python#105136)

Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)
(cherry picked from commit 01b42f9)
vstinner added a commit that referenced this pull request May 31, 2023
@vstinner
[3.11] gh-105096: Reformat wave documentation (#105136) (#105138) (#1…
5de6ca5 
…05155)

[3.12] gh-105096: Reformat wave documentation (#105136) (#105138)

gh-105096: Reformat wave documentation (#105136)

Add ".. class::" markups in the wave documentation.

* Reformat also wave.py (minor PEP 8 changes).
* Remove redundant "import struct": it's already imported at top
  level.
* Remove wave.rst from .nitignore

(cherry picked from commit 85e5d03)
(cherry picked from commit 01b42f9)
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.