GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clarify that error messages are better with PEP 701 by pablogsal · Pull Request #105150 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented May 31, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--105150.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
Clarify that error messages are better with PEP 701
4ceb60a
@pablogsal pablogsal added skip issue skip news needs backport to 3.12 only security fixes labels May 31, 2023
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels May 31, 2023
@pablogsal

pablogsal commented May 31, 2023

Copy link
Copy Markdown
Member Author

CC: @mgmacias95
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
fixup! Clarify that error messages are better with PEP 701
66f93b1
mgmacias95
mgmacias95 reviewed May 31, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal @mgmacias95
Update Doc/whatsnew/3.12.rst
7ca09c3 
Co-authored-by: Marta Gómez Macías <[email protected]>
@mgmacias95

mgmacias95 commented May 31, 2023

Copy link
Copy Markdown
Contributor

For some reason the code is not highlighted in the preview docs:
image

Is this expected? The other syntax error blocks have the code higlighted:
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Seems that the lexer in sphinx has problems with the $ in the example. I will replace this by another kind of syntax error:

Screenshot 2023-05-31 at 21 43 14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and others added 3 commits May 31, 2023 21:42
@pablogsal
fixup! Update Doc/whatsnew/3.12.rst
06174da
@pablogsal
fixup! fixup! Update Doc/whatsnew/3.12.rst
6fe2f27
@pablogsal
Merge branch 'main' into better_701
8d160b7
@pablogsal
pablogsal merged commit 60cfc6d into python:main May 31, 2023
@pablogsal
pablogsal deleted the better_701 branch May 31, 2023 21:01
@miss-islington

miss-islington commented May 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2023
@pablogsal @mgmacias95 @miss-islington
Clarify that error messages are better with PEP 701 (pythonGH-105150)
f623580 
(cherry picked from commit 60cfc6d)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Marta Gómez Macías <[email protected]>
@bedevere-bot

bedevere-bot commented May 31, 2023

Copy link
Copy Markdown

GH-105169 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 31, 2023
hugovk pushed a commit that referenced this pull request Jun 5, 2023
@miss-islington @pablogsal @mgmacias95
[3.12] Clarify that error messages are better with PEP 701 (GH-105150) (
dbc179e 
#105169)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Marta Gómez Macías <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mgmacias95 mgmacias95 mgmacias95 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @mgmacias95 @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.