GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc by iritkatriel · Pull Request #105190 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jun 1, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PyErr_PrintEx now populates also sys.last_exc, and the old variables are still populated by deprecated.

  • Issue: Add sys.last_exc, deprecate sys.last_type, sys.last_value and sys.last_traceback #102778

📚 Documentation preview 📚: https://cpython-previews--105190.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-102778: update documentation of PyErr_PrintEx regarding sys.…
2157f04 
…last_exc
@iritkatriel iritkatriel added docs Documentation in the Doc dir needs backport to 3.12 only security fixes labels Jun 1, 2023
@bedevere-bot bedevere-bot added awaiting core review skip news labels Jun 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
Add sys.last_exc, deprecate sys.last_type, sys.last_value and sys.last_traceback #102778
Closed
iritkatriel and others added 2 commits June 1, 2023 12:34
@iritkatriel
Merge branch 'main' into PyErr_Print-doc
9cfa6a4
@iritkatriel
traceback module too
1d4907b
@iritkatriel iritkatriel changed the title gh-102778: update documentation of PyErr_PrintEx regarding sys.last_exc gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc Jun 1, 2023
@iritkatriel
whitespace
8f3788f
@iritkatriel
iritkatriel requested a review from terryjreedy June 1, 2023 18:23
terryjreedy
terryjreedy requested changes Jun 1, 2023
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/exceptions.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Jun 1, 2023
@bedevere-bot

bedevere-bot commented Jun 1, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel @terryjreedy
Apply suggestions from code review
00a6936 
Co-authored-by: Terry Jan Reedy <[email protected]>
@iritkatriel

iritkatriel commented Jun 2, 2023

Copy link
Copy Markdown
Member Author

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jun 2, 2023
@bedevere-bot

bedevere-bot commented Jun 2, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from terryjreedy June 2, 2023 10:21
terryjreedy
terryjreedy approved these changes Jun 2, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jun 2, 2023
@iritkatriel
iritkatriel merged commit 0dafc78 into python:main Jun 2, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 2, 2023
@miss-islington

miss-islington commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2023
@iritkatriel @miss-islington
pythongh-102778: update documentation of PyErr_PrintEx and traceback.…
de2b136 
…print_last() regarding sys.last_exc (pythonGH-105190)

(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 2, 2023

Copy link
Copy Markdown

GH-105246 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 2, 2023
iritkatriel added a commit that referenced this pull request Jun 2, 2023
@miss-islington @iritkatriel
[3.12] gh-102778: update documentation of PyErr_PrintEx and traceback…
00fe618 
….print_last() regarding sys.last_exc (GH-105190) (#105246)

gh-102778: update documentation of PyErr_PrintEx and traceback.print_last() regarding sys.last_exc (GH-105190)
(cherry picked from commit 0dafc78)

Co-authored-by: Irit Katriel <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
@iritkatriel
iritkatriel deleted the PyErr_Print-doc branch July 25, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @bedevere-bot @miss-islington @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.