GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-89886: Rely on HAVE_SYS_TIME_H (GH-105058) by miss-islington · Pull Request #105192 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Quoting autoconf (v2.71):

All current systems provide time.h; it need not be checked for.
Not all systems provide sys/time.h, but those that do, all allow
you to include it and time.h simultaneously.

(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Improve and simplify configure.ac checks #89886

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland @miss-islington
pythongh-89886: Rely on HAVE_SYS_TIME_H (pythonGH-105058)
4a4bc4f
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.
(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@miss-islington
miss-islington requested review from corona10 and erlend-aasland as code owners June 1, 2023 11:38
@bedevere-bot bedevere-bot added the awaiting review label Jun 1, 2023
This was referenced Jun 1, 2023
Improve and simplify configure.ac checks #89886
Closed
gh-89886: Rely on HAVE_SYS_TIME_H #105058
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 1, 2023
erlend-aasland
erlend-aasland approved these changes Jun 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 1, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) June 1, 2023 11:38
@erlend-aasland
erlend-aasland merged commit 6375287 into python:3.12 Jun 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 1, 2023
@miss-islington
miss-islington deleted the backport-9ab587b-3.12 branch June 1, 2023 12:08
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.