GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89886: Rely on HAVE_SYS_TIME_H by erlend-aasland · Pull Request #105058 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Quoting autoupdate (v2.71):

All current systems provide time.h; it need not be checked for.
Not all systems provide sys/time.h, but those that do, all allow
you to include it and time.h simultaneously.
  • Issue: Improve and simplify configure.ac checks #89886

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-89886: Rely on HAVE_SYS_TIME_H
1a8d41e 
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.
@erlend-aasland
erlend-aasland requested a review from corona10 as a code owner May 29, 2023 11:54
@erlend-aasland
erlend-aasland requested review from gpshead and zware May 29, 2023 11:54
@bedevere-bot bedevere-bot added the awaiting core review label May 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
Improve and simplify configure.ac checks #89886
Closed
@erlend-aasland erlend-aasland added the skip news label May 29, 2023
@erlend-aasland
Fixup pyexpat detection
de000c6
@hugovk hugovk mentioned this pull request May 29, 2023
RtD docs previews: Cancel building PRs if no changes in Doc dir #104100
Merged
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
@bedevere-bot

bedevere-bot commented May 29, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit de000c6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2023
brettcannon
brettcannon approved these changes May 29, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 29, 2023
@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label May 29, 2023
@erlend-aasland

erlend-aasland commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

On hold until test_import and test_peg_generator issues have been resolved on main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware
zware reviewed May 30, 2023
View reviewed changes
Comment thread Modules/expat/xmlparse.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 2 commits May 30, 2023 22:44
@erlend-aasland
Pull in main
f3bb618
@erlend-aasland
Address review: remove confusingly named 'have_libexpat'
92350d7 
Simply use ac_cv_header_sys_time_h for PY_STDLIB_MOD
erlend-aasland
erlend-aasland commented May 30, 2023
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 4 commits May 31, 2023 21:43
@erlend-aasland
Pull in main
a50f2dc
@erlend-aasland
Revert _elementtree change
e3271f5
@erlend-aasland
Regen
00b82b7
@erlend-aasland
Revert expat change
3988c9c
@erlend-aasland

erlend-aasland commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Ok, I think we can land this now. Thanks for the review! It helps with more eyes 👀
zware reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 9ab587b into python:main Jun 1, 2023
@miss-islington

miss-islington commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 1, 2023
@erlend-aasland
erlend-aasland deleted the sys/time.h branch June 1, 2023 11:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2023
@erlend-aasland @miss-islington
pythongh-89886: Rely on HAVE_SYS_TIME_H (pythonGH-105058)
4a4bc4f 
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.
(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 1, 2023

Copy link
Copy Markdown

GH-105192 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 1, 2023
erlend-aasland added a commit that referenced this pull request Jun 1, 2023
@miss-islington @erlend-aasland
[3.12] gh-89886: Rely on HAVE_SYS_TIME_H (GH-105058) (#105192)
6375287 
Quoting autoconf (v2.71):

    All current systems provide time.h; it need not be checked for.
    Not all systems provide sys/time.h, but those that do, all allow
    you to include it and time.h simultaneously.

(cherry picked from commit 9ab587b)

Co-authored-by: Erlend E. Aasland <[email protected]>
This was referenced Jun 1, 2023
GH-89886: Bump autoconf to version 2.71 #104925
Merged
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments
@brettcannon brettcannon brettcannon approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @miss-islington @brettcannon @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.