GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal by iritkatriel · Pull Request #105195 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jun 1, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Fixing Copy on Writes from reference counting and immortal objects #84436

📚 Documentation preview 📚: https://cpython-previews--105195.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis b…
34f3010 
…ecoming immortal
@iritkatriel iritkatriel added the needs backport to 3.12 only security fixes label Jun 1, 2023
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jun 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
Fixing Copy on Writes from reference counting and immortal objects #84436
Closed
@iritkatriel
iritkatriel requested a review from ericsnowcurrently June 1, 2023 13:35
@iritkatriel

iritkatriel commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

CC @eduardo-elizondo .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
use :c:data: instead of :const:
b0997c0
@eduardo-elizondo eduardo-elizondo mentioned this pull request Jun 4, 2023
Immortal objects and the C API docs #104597
Closed
erlend-aasland
erlend-aasland approved these changes Jun 5, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 5, 2023
@corona10 corona10 mentioned this pull request Jun 5, 2023
gh-103906: Remove immortal refcounting in compile/marshal.c #103922
Merged
JelleZijlstra
JelleZijlstra previously requested changes Jun 5, 2023
View reviewed changes
Comment thread Doc/c-api/bool.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/bool.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 5, 2023
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jun 5, 2023
iritkatriel added 2 commits June 5, 2023 15:20
@iritkatriel
add link to the PEP
52a846b
@iritkatriel
use :c:data:
103aabb
iritkatriel
iritkatriel commented Jun 5, 2023
View reviewed changes
Comment thread Doc/c-api/bool.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/bool.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/none.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/slice.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added 2 commits June 5, 2023 18:44
@iritkatriel
Maybe fix the links.
864ed5d
@iritkatriel
Merge branch 'main' into immortals-doc
3c57a95
@iritkatriel

iritkatriel commented Jun 21, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jun 21, 2023
@bedevere-bot

bedevere-bot commented Jun 21, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland, @JelleZijlstra: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested review from JelleZijlstra and erlend-aasland June 21, 2023 15:21
carljm
carljm reviewed Jun 21, 2023
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few more broken references to fix.

Since bool.rst is such a small file I'd be tempted to also just fix in passing the two erroring references to Py_True and Py_False near the top of the file (line 9), but that's up to you; that line isn't changed in the PR otherwise.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/c-api/bool.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/bool.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/bool.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/slice.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel and others added 2 commits June 21, 2023 19:12
@iritkatriel @carljm
Apply suggestions from code review
7330a7f 
Co-authored-by: Carl Meyer <[email protected]>
@iritkatriel
fix :const:->:c:data:
4281b5b
carljm
carljm approved these changes Jun 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jun 21, 2023
erlend-aasland
erlend-aasland approved these changes Jun 21, 2023
View reviewed changes
@iritkatriel
iritkatriel dismissed JelleZijlstra’s stale review June 21, 2023 20:12

Changes made and approved by other reviewers.

@iritkatriel
iritkatriel merged commit a239272 into python:main Jun 21, 2023
@miss-islington

miss-islington commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 21, 2023
@bedevere-bot

bedevere-bot commented Jun 21, 2023

Copy link
Copy Markdown

GH-105977 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2023
@iritkatriel @miss-islington
pythongh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis b…
4446a42 
…ecoming immortal (pythonGH-105195)

(cherry picked from commit a239272)

Co-authored-by: Irit Katriel <[email protected]>
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@iritkatriel @bentasker
pythongh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis b…
40a23a1 
…ecoming immortal (python#105195)
kumaraditya303 pushed a commit that referenced this pull request Jun 26, 2023
@miss-islington @iritkatriel
[3.12] gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis …
592d1ea 
…becoming immortal (GH-105195) (#105977)

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal (GH-105195)
(cherry picked from commit a239272)

Co-authored-by: Irit Katriel <[email protected]>
@iritkatriel
iritkatriel deleted the immortals-doc branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@iritkatriel @bedevere-bot @miss-islington @carljm @JelleZijlstra @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.