GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92536: Argument Clinic no longer emits PyUnicode_READY() by vstinner · Pull Request #105208 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since Python 3.12, PyUnicode_READY() does nothing and always returns 0.

  • Issue: PEP 623: Remove wstr from Unicode #92536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Jun 1, 2023
@vstinner
vstinner requested a review from a team as a code owner June 1, 2023 22:22
@bedevere-bot bedevere-bot added the awaiting core review label Jun 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
PEP 623: Remove wstr from Unicode #92536
Closed
@vstinner
vstinner force-pushed the clinic_unicode_ready branch from e19ae66 to 4960003 Compare June 1, 2023 22:29
@vstinner
vstinner requested review from berkerpeksag, brettcannon, encukou, ericsnowcurrently, erlend-aasland, ncoghlan and warsaw as code owners June 1, 2023 22:29
@vstinner

vstinner commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

See also PR #105210.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 1, 2023
gh-92536: Remove PyUnicode_READY() calls #105210
Merged
vstinner added 2 commits June 2, 2023 00:36
@vstinner
pythongh-92536: Argument Clinic no longer emits PyUnicode_READY()
c591ad7 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
@vstinner
clinic.py also checks for .cpp files: PC/_wmimodule.cpp
2629844
@vstinner
vstinner force-pushed the clinic_unicode_ready branch from b321f5d to 2629844 Compare June 1, 2023 22:36
@vstinner
vstinner merged commit cbb9ba8 into python:main Jun 1, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 1, 2023
@vstinner
vstinner deleted the clinic_unicode_ready branch June 1, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@warsaw warsaw Awaiting requested review from warsaw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.