GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92536: Remove PyUnicode_READY() calls by vstinner · Pull Request #105210 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Since Python 3.12, PyUnicode_READY() does nothing and always returns 0.

  • Issue: PEP 623: Remove wstr from Unicode #92536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-92536: Remove PyUnicode_READY() calls
63ba3dc 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
@vstinner vstinner added the skip news label Jun 1, 2023
@vstinner
vstinner requested review from abalkin, brettcannon, corona10, encukou, ericsnowcurrently, iritkatriel, lysnikolaou, markshannon, ncoghlan, pablogsal, pganssle, rhettinger and warsaw as code owners June 1, 2023 22:31
@bedevere-bot bedevere-bot added the awaiting core review label Jun 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
PEP 623: Remove wstr from Unicode #92536
Closed
@vstinner vstinner mentioned this pull request Jun 1, 2023
gh-92536: Argument Clinic no longer emits PyUnicode_READY() #105208
Merged
@vstinner

vstinner commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

See also PR #105208.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
One more change in getargs.c
87a3b7a
@vstinner
vstinner merged commit ef30093 into python:main Jun 1, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 1, 2023
@vstinner
vstinner deleted the remove_pyunicode_ready branch June 1, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.