GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104614: Fix potential ref. leak in _testcapimodule/get_basic_static_type() by erlend-aasland · Pull Request #105225 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 2, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Type object's ob_type does not get set when tp_bases is set before PyType_Ready #104614

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-104614: Fix potential ref. leak in _testcapimodule/get_basic…
5319302 
…_static_type()
@erlend-aasland erlend-aasland added skip news needs backport to 3.12 only security fixes labels Jun 2, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 2, 2023
Type object's ob_type does not get set when tp_bases is set before PyType_Ready #104614
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 2, 2023
gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() #105122
Merged
ericsnowcurrently
ericsnowcurrently approved these changes Jun 2, 2023
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 2, 2023
@erlend-aasland
erlend-aasland merged commit e01b04c into python:main Jun 2, 2023
@miss-islington

miss-islington commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 2, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 2, 2023
@erlend-aasland @miss-islington
pythongh-104614: Fix potential ref. leak in _testcapimodule/get_basic…
4acf6fa 
…_static_type() (pythonGH-105225)

(cherry picked from commit e01b04c)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
erlend-aasland deleted the fix-test branch June 2, 2023 16:44
@bedevere-bot

bedevere-bot commented Jun 2, 2023

Copy link
Copy Markdown

GH-105248 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 2, 2023
erlend-aasland added a commit that referenced this pull request Jun 2, 2023
@miss-islington @erlend-aasland
[3.12] gh-104614: Fix potential ref. leak in _testcapimodule/get_basi…
72d5dfa 
…c_static_type() (GH-105225) (#105248)

(cherry picked from commit e01b04c)

Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.