GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-89886: Use Autoconf quadrigraphs where appropriate by erlend-aasland · Pull Request #105226 · python/cpython Conversation
|
|
@corona10 are you ok with this? In my editor (Vim), this fix is very helpful, not specifically because of the highlighting, but also because it enables Vim to correctly recognise closing parentheses and brackets. This makes hacking Autoconf way easier, since I can quickly verify opening/closing brackets and parentheses using the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Yeah yeah, I understood what you intended. I have the same issue with my vim editor. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I don't think we need to maintain our own Autoconf docs; the GNU Autoconf docs are well written and full of good examples. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The code correctly works as expected. %:@include is surprising and looks specific to autotools, whereas C uses #include. The benefit is to fix syntax highlight? I'm not convinced that it's worth it.
@corona10 are you ok with this? In my editor (Vim), this fix is very helpful, not specifically because of the highlighting, but also because it enables Vim to correctly recognise closing parentheses and brackets. This makes hacking Autoconf way easier, since I can quickly verify opening/closing brackets and parentheses using the % char.
Well, that was just my opinion. Now it's up to you. You're way more active on changing configure than me :-)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Thanks for you input. I'll abide with Dong-hee's final word on this :) I won't repeat my arguments as to why I think this is worth it (see #105226 (comment)), but (surprise, surprise) I still would like to land this :) An alternative could be to make sure strings including |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's go.
From my conservative view it is +0.5.. but doing something is always better than doing nothing.
Someone may complain but soon adapt to a new convention.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
As I said in #105226 (comment), there is already precedent for using quadrigraphs in Thanks, both! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry @erlend-aasland, I had trouble checking out the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-105423 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.