GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` (GH-105281) by miss-islington · Pull Request #105318 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood [email protected]

  • Issue: typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood @miss-islington
pythongh-105280: Ensure isinstance([], collections.abc.Mapping) alw…
c004e38 
…ays evaluates to `False` (pythonGH-105281)

(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood <[email protected]>
@miss-islington
miss-islington requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners June 5, 2023 14:10
@bedevere-bot bedevere-bot added the awaiting review label Jun 5, 2023
This was referenced Jun 5, 2023
typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280
Closed
gh-105280: Ensure isinstance([], collections.abc.Mapping) always evaluates to False #105281
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Jun 5, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) June 5, 2023 14:11
@AlexWaygood AlexWaygood self-assigned this Jun 5, 2023
@AlexWaygood
AlexWaygood merged commit 2031238 into python:3.12 Jun 5, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Jun 5, 2023
@miss-islington
miss-islington deleted the backport-08756db-3.12 branch June 5, 2023 14:51
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.