GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` by AlexWaygood · Pull Request #105281 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jun 4, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Ensure isinstance([], collections.abc.Mapping) always evaluates to …
c17b8ed 
…`False`
@AlexWaygood AlexWaygood added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory topic-typing needs backport to 3.12 only security fixes labels Jun 4, 2023
@AlexWaygood
AlexWaygood requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners June 4, 2023 11:19
@bedevere-bot bedevere-bot added the awaiting core review label Jun 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 4, 2023
typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280
Closed
@AlexWaygood

AlexWaygood commented Jun 4, 2023

Copy link
Copy Markdown
Member Author

I've run the third-party test workflow we have at typing_extensions on a version of this PR, and it doesn't cause any regressions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 4, 2023
gh-105237: Allow calling issubclass(X, typing.Protocol) again #105239
Merged
Backport recent fixes to Protocol from 3.12 python/typing_extensions#218
Merged
AlexWaygood
AlexWaygood commented Jun 5, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Add the cleanup before changing the state
612c551
AlexWaygood
AlexWaygood commented Jun 5, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
don't needlessly break compatibility with typing_extensions
99ec54c
AlexWaygood
AlexWaygood commented Jun 5, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
nit
55368cd
JelleZijlstra
JelleZijlstra approved these changes Jun 5, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 5, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) June 5, 2023 13:35
@AlexWaygood
Merge branch 'main' into fix-gc-protocol-bug
d498ff3
@AlexWaygood
AlexWaygood merged commit 08756db into python:main Jun 5, 2023
@miss-islington

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 5, 2023
@AlexWaygood
AlexWaygood deleted the fix-gc-protocol-bug branch June 5, 2023 14:11
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

GH-105318 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
@AlexWaygood @miss-islington
pythongh-105280: Ensure isinstance([], collections.abc.Mapping) alw…
c004e38 
…ays evaluates to `False` (pythonGH-105281)

(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 5, 2023
AlexWaygood added a commit that referenced this pull request Jun 5, 2023
@miss-islington @AlexWaygood
[3.12] gh-105280: Ensure isinstance([], collections.abc.Mapping) al…
2031238 
…ways evaluates to `False` (GH-105281) (#105318)

gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` (GH-105281)
(cherry picked from commit 08756db)

Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory topic-typing type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.