GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-102304: Fix Py_INCREF() stable ABI in debug mode (#104763) by vstinner · Pull Request #105352 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 6, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When Python is built in debug mode (if the Py_REF_DEBUG macro is defined), the Py_INCREF() and Py_DECREF() function are now always implemented as opaque functions to avoid leaking implementation details like the "_Py_RefTotal" variable or the
_Py_DecRefTotal_DO_NOT_USE_THIS() function.

  • Remove _Py_IncRefTotal_DO_NOT_USE_THIS() and _Py_DecRefTotal_DO_NOT_USE_THIS() from the stable ABI.
  • Remove _Py_NegativeRefcount() from limited C API.

(cherry picked from commit 92022d8)

  • Issue: Move _Py_RefTotal to PyInterpreterState #102304

📚 Documentation preview 📚: https://cpython-previews--105352.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested a review from a team as a code owner June 6, 2023 09:23
@bedevere-bot bedevere-bot added the awaiting core review label Jun 6, 2023
This was referenced Jun 6, 2023
Move _Py_RefTotal to PyInterpreterState #102304
Closed
gh-102304: Fix Py_INCREF() stable ABI in debug mode #104763
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 6, 2023
@vstinner

vstinner commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

Oh. If this change is merged, Doc/whatsnew/3.13.rst must be updated in the main branch: the build change happens in Python 3.12, not 3.13.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 6, 2023
[3.12] gh-102304: doc: Add links to Stable ABI and Limited C API (GH-105345) #105347
Closed
@vstinner

vstinner commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

PR #105347 doc change should be merged first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 6, 2023
gh-102304: Enhance Simple ABI doc #105351
Merged
@vstinner
pythongh-102304: Fix Py_INCREF() stable ABI in debug mode (python#104763
fee188d 
)

When Python is built in debug mode (if the Py_REF_DEBUG macro is
defined), the Py_INCREF() and Py_DECREF() function are now always
implemented as opaque functions to avoid leaking implementation
details like the "_Py_RefTotal" variable or the
_Py_DecRefTotal_DO_NOT_USE_THIS() function.

* Remove _Py_IncRefTotal_DO_NOT_USE_THIS() and
  _Py_DecRefTotal_DO_NOT_USE_THIS() from the stable ABI.
* Remove _Py_NegativeRefcount() from limited C API.

(cherry picked from commit 92022d8)
@vstinner
vstinner force-pushed the incref_debug312 branch from 222c6d9 to fee188d Compare June 6, 2023 13:37
@vstinner
vstinner merged commit 2bbb557 into python:3.12 Jun 6, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 6, 2023
@vstinner
vstinner deleted the incref_debug312 branch June 6, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.