GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-102304: Enhance Simple ABI doc by vstinner · Pull Request #105351 · python/cpython

Conversation

vstinner commented Jun 6, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Move _Py_RefTotal to PyInterpreterState #102304

📚 Documentation preview 📚: https://cpython-previews--105351.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-102304: Enhance Simple ABI doc

0f8be07

bedevere-bot added the awaiting core review label

Jun 6, 2023

bedevere-bot mentioned this pull request

Jun 6, 2023

Move _Py_RefTotal to PyInterpreterState #102304

Closed

vstinner mentioned this pull request

Jun 6, 2023

gh-102304: doc: Add links to Stable ABI and Limited C API #105345

Merged

vstinner added the skip news label

Jun 6, 2023

encukou reviewed

Jun 6, 2023

View reviewed changes

Comment thread

Makefile.pre.in Outdated

		# - Lib/test/test_stable_abi_ctypes.py
		# - Modules/_testcapi_feature_macros.inc
		# - PC/python3dll.c
		# https://devguide.python.org/developer-workflow/c-api/#adding-a-new-definition-to-the-limited-api

encukou Jun 6, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the list of files, which will become outdated in time?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

encukou Jun 6, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or: why is this needed? I can keep it up to date if there's a need for it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Jun 6, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to know which files are generated by make by reading the Makefile. I would prefer to not have to open a web browser. Moreover, the linked URL doesn't list which files are modified.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

encukou Jun 6, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commnand to list them is ./python Tools/build/stable_abi.py --list . (and with #105355 the dot will be unnecessary.)
Is that enough? If not I can add a check to make sure Makefile is up to date.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Jun 6, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to worry more than me that such comment can be outdated. I can survive without this comment, so I just removed it. I would like to backport my C API doc change to 3.12 to unblock PR #105352 fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Remove regen-limited-abi comment

eb4dd7c

So it's no longer needed to maintain it.

encukou approved these changes

Jun 6, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Jun 6, 2023

encukou merged commit 0202aa0 into python:main

Jun 6, 2023

encukou commented Jun 6, 2023

Copy link

Copy Markdown

Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Jun 6, 2023

vstinner deleted the limited_capi_enhance branch

June 6, 2023 12:38

vstinner added a commit to vstinner/cpython that referenced this pull request

Jun 6, 2023


          pythongh-102304: Fix up Simple ABI doc (pythonGH-105351)

065f681

(cherry picked from commit 0202aa0)

vstinner commented Jun 6, 2023

Copy link

Copy Markdown

Member Author

Thanks for the review. I wrote a new PR for 3.12 which combines the 2 doc changes: PR #105371.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit that referenced this pull request

Jun 6, 2023


          [3.12] gh-102304: doc: Add links to Stable ABI and Limited C API (#10…

82ab13c

…5345) (#105371)

* gh-102304: doc: Add links to Stable ABI and Limited C API (#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* gh-102304: Fix up Simple ABI doc (GH-105351)

(cherry picked from commit 0202aa0)

AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request

Sep 26, 2023


          [3.12] pythongh-102304: doc: Add links to Stable ABI and Limited C API (

967be20

python#105345) (python#105371)

* pythongh-102304: doc: Add links to Stable ABI and Limited C API (python#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* pythongh-102304: Fix up Simple ABI doc (pythonGH-105351)

(cherry picked from commit 0202aa0)
(cherry picked from commit 82ab13c)

AA-Turner mentioned this pull request

Sep 26, 2023

[3.11] gh-102304: doc: Add links to Stable ABI and Limited C API (#105345) (#105371) #109901

Merged

AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request

Sep 26, 2023


          [3.11] pythongh-102304: doc: Add links to Stable ABI and Limited C API (

e4154d4

python#105345) (python#105371)

* pythongh-102304: doc: Add links to Stable ABI and Limited C API (python#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* pythongh-102304: Fix up Simple ABI doc (pythonGH-105351)

(cherry picked from commit 0202aa0)
(cherry picked from commit 82ab13c)

Reviewers

encukou

encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Jun 6, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

encukou Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

encukou Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

vstinner Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

encukou Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

vstinner Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

encukou commented Jun 6, 2023

Uh oh!

vstinner commented Jun 6, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vstinner commented Jun 6, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.