GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104783: locale.getencoding() fallback uses FS encoding by vstinner · Pull Request #105381 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The locale.getencoding() function now uses
sys.getfilesystemencoding() if _locale.getencoding() is missing, instead of calling locale.getdefaultlocale().

  • Issue: Remove locale.resetlocale() function in Python 3.13 #104783

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-104783: locale.getencoding() fallback uses FS encoding
13a71f6 
The locale.getencoding() function now uses
sys.getfilesystemencoding() if _locale.getencoding() is missing,
instead of calling locale.getdefaultlocale().
@bedevere-bot bedevere-bot added the awaiting core review label Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Remove locale.resetlocale() function in Python 3.13 #104783
Closed
@vstinner

vstinner commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

@methane: This change is more a theorical change, since it doesn't affect CPython which always has the _locale extension. But it's needed to prepare the removal of the deprecated locale.getdefaultencoding() function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

I don't think that a Changelog entry is needed, since it doesn't affect CPython users.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Jun 6, 2023
@vstinner
vstinner merged commit b1a91d2 into python:main Jun 6, 2023
@vstinner
vstinner deleted the fs_encoding branch June 6, 2023 14:55
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 6, 2023
methane
methane reviewed Jun 6, 2023
View reviewed changes
Comment thread Lib/locale.py
# LANG not set, default to UTF-8
encoding = 'utf-8'
return encoding
return _encoding

@methane methane Jun 6, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return sys.getfilesystemencoding() would be enough.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Jun 6, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created PR #105401 to change this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @methane @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.