GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104783: locale.getlocale() calls sys.getfilesystemencoding() by vstinner · Pull Request #105401 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

locale.getlocale() always calls sys.getfilesystemencoding(), instead of calling it only once.

  • Issue: Remove locale.resetlocale() function in Python 3.13 #104783

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-104783: locale.getlocale() calls sys.getfilesystemencoding()
eed65ea 
locale.getlocale() always calls sys.getfilesystemencoding(), instead
of calling it only once.
@bedevere-bot bedevere-bot added the awaiting core review label Jun 6, 2023
@vstinner vstinner added skip news and removed awaiting core review labels Jun 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Remove locale.resetlocale() function in Python 3.13 #104783
Closed
@vstinner

vstinner commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

@methane: I added _encoding variable to be able to calle locale.getencoding() during Python finalization, when modules attributes are set to None. But maybe it's not needed. By the way, Python tries to keep sys attributes as long as posible. So I wrote this PR to change it :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 6, 2023
gh-104783: locale.getencoding() fallback uses FS encoding #105381
Merged
methane
methane approved these changes Jun 6, 2023
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Jun 6, 2023
@vstinner
vstinner enabled auto-merge (squash) June 6, 2023 18:07
@vstinner
vstinner merged commit 221d703 into python:main Jun 6, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 6, 2023
@vstinner
vstinner deleted the locale_getencoding_call branch June 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @methane @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.