GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-105375: Improve error handling in sqlite3 collation callback (GH-105412) by miss-islington · Pull Request #105441 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Check for error after each call to PyUnicode_FromStringAndSize().
(cherry picked from commit a24a780)

Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Incorrect error handling for APIs that can raise exceptions #105375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in sqlite3 collation callback (…
4da6297 
…pythonGH-105412)

Check for error after each call to PyUnicode_FromStringAndSize().
(cherry picked from commit a24a780)

Co-authored-by: Erlend E. Aasland <[email protected]>
@miss-islington
miss-islington requested review from berkerpeksag and erlend-aasland as code owners June 7, 2023 11:10
@bedevere-bot bedevere-bot added the awaiting review label Jun 7, 2023
This was referenced Jun 7, 2023
Incorrect error handling for APIs that can raise exceptions #105375
Closed
gh-105375: Improve error handling in sqlite3 collation callback #105412
Merged
@erlend-aasland
erlend-aasland enabled auto-merge (squash) June 7, 2023 11:11
erlend-aasland
erlend-aasland approved these changes Jun 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 7, 2023
@AlexWaygood AlexWaygood mentioned this pull request Jun 7, 2023
[3.11] gh-105286: Further improvements to typing.py docstrings (GH-105363) #105417
Merged
@erlend-aasland
Merge branch '3.11' into backport-a24a780-3.11
f2a6ed2
@erlend-aasland
erlend-aasland merged commit 571ec56 into python:3.11 Jun 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 7, 2023
@miss-islington
miss-islington deleted the backport-a24a780-3.11 branch June 7, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.