GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-105286: Further improvements to `typing.py` docstrings (GH-105363) by JelleZijlstra · Pull Request #105417 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jun 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 9a89f1b)

  • Issue: Improve typing.py docstrings #105286

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AlexWaygood @JelleZijlstra
[3.11] pythongh-105286: Further improvements to typing.py docstrings (
07a6713
pythonGH-105363).

(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner and gvanrossum as code owners June 7, 2023 00:25
@bedevere-bot bedevere-bot added the awaiting core review label Jun 7, 2023
This was referenced Jun 7, 2023
Improve typing.py docstrings #105286
Closed
gh-105286: Further improvements to typing.py docstrings #105363
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 7, 2023
AlexWaygood
AlexWaygood reviewed Jun 7, 2023
View reviewed changes
Comment thread Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra @AlexWaygood
Update Lib/typing.py
1c0fdc8
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Jun 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 7, 2023
@AlexWaygood
Merge branch '3.11' into backport-9a89f1b-3.11
30ab694
@AlexWaygood
AlexWaygood enabled auto-merge (squash) June 7, 2023 13:11
@AlexWaygood AlexWaygood self-assigned this Jun 7, 2023
@AlexWaygood

AlexWaygood commented Jun 7, 2023

Copy link
Copy Markdown
Member

I have no idea why the "Check if generated files are up to date" check is failing (I was hoping merging in main would fix it) ☹️

I won't be able to merge past it, since it's a "required" CI check.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
Merge branch '3.11' into backport-9a89f1b-3.11
f0a8369
@JelleZijlstra

JelleZijlstra commented Jun 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Weirdly the check doesn't fail on other 3.11 PRs. I guess I'll try merging 3.11 in again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
Merge branch '3.11' into backport-9a89f1b-3.11
cf09e1b
@AlexWaygood

AlexWaygood commented Jun 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Weirdly the check doesn't fail on other 3.11 PRs

It seems to be failing on all PRs that touch .py files, but not on PRs that only touch .rst files. Presumably because different CI checks run on PRs that are deemed to be docs-only PRs

JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Jun 7, 2023

Copy link
Copy Markdown
Member

Same failures on:

  • [3.11] typing: Improve documentation of generic classes and aliases (#105369) #105454
  • [3.11] gh-103171: Revert undocumented behaviour change for runtime-checkable protocols decorated with @final #105445
  • [3.11] gh-105375: Improve error handling in sqlite3 collation callback (GH-105412) #105441
  • [3.11] gh-104692: Include commoninstall as a prerequisite for bininstall (GH-104693) #105429
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra

JelleZijlstra commented Jun 7, 2023

Copy link
Copy Markdown
Member Author

Opening an issue in a moment

AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra JelleZijlstra mentioned this pull request Jun 7, 2023
3.11: "Check if generated files are up to date" is failing due to autoconf version #105455
Closed
@erlend-aasland
Merge branch '3.11' into backport-9a89f1b-3.11
d5361d8
@AlexWaygood
AlexWaygood merged commit 3a195f3 into python:3.11 Jun 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @AlexWaygood @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.