GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103171: Forward-port new tests for runtime-checkable protocols decorated with `@final` by AlexWaygood · Pull Request #105473 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jun 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Forward-port of the tests that were added to the 3.11 branch in #105445

  • Issue: Typing: undocumented behaviour change for protocols decorated with @final and @runtime_checkable in 3.11 #103171

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-103171: Forward-port new tests for runtime-checkable protoco…
e96c2e8 
…ls decorated with `@final`

Forward-port of the tests that were added to the 3.11 branch in python#105445
@AlexWaygood AlexWaygood added skip news topic-typing labels Jun 7, 2023
@AlexWaygood
AlexWaygood requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners June 7, 2023 21:58
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 7, 2023
Typing: undocumented behaviour change for protocols decorated with @final and @runtime_checkable in 3.11 #103171
Closed
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Jun 7, 2023
JelleZijlstra
JelleZijlstra approved these changes Jun 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 7, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) June 7, 2023 22:19
@AlexWaygood AlexWaygood changed the title gh-103171: Forward-port new tests for runtime-checkable protocols dec orated with @final gh-103171: Forward-port new tests for runtime-checkable protocols decorated with @final Jun 7, 2023
@AlexWaygood
AlexWaygood merged commit f5df347 into python:main Jun 7, 2023
@miss-islington

miss-islington commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 7, 2023
@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105474 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @miss-islington
pythongh-103171: Forward-port new tests for runtime-checkable protoco…
0e124fc 
…ls dec orated with `@final` (pythonGH-105473)

Forward-port of the tests that were added to the 3.11 branch in pythonGH-105445
(cherry picked from commit f5df347)

Co-authored-by: Alex Waygood <[email protected]>
@AlexWaygood
AlexWaygood deleted the Finalprotocol branch June 7, 2023 22:26
@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105474 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood added a commit that referenced this pull request Jun 7, 2023
@miss-islington @AlexWaygood
[3.12] gh-103171: Forward-port new tests for runtime-checkable protoc…
4b2263e 
…ols decorated with `@final` (GH-105473) (#105474)

Forward-port of the tests that were added to the 3.11 branch in GH-105445
(cherry picked from commit f5df347)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.