GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105375: Improve error handling in PyUnicode_BuildEncodingMap() by erlend-aasland · Pull Request #105491 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Issue:

  • Incorrect error handling for APIs that can raise exceptions #105375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
erlend-aasland added 2 commits June 8, 2023 09:24
@erlend-aasland
pythongh-105375: Improve error handling in PyUnicode_BuildEncodingMap()
17065c4
@erlend-aasland
Add NEWS
a446413
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 8, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2023
Incorrect error handling for APIs that can raise exceptions #105375
Closed
18 tasks done
@erlend-aasland
erlend-aasland requested a review from vstinner June 8, 2023 12:23
erlend-aasland
erlend-aasland commented Jun 9, 2023
View reviewed changes
Comment thread Objects/unicodeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Update Objects/unicodeobject.c
94ae5bd
@erlend-aasland
erlend-aasland merged commit 555be81 into python:main Jun 11, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 11, 2023
@erlend-aasland
erlend-aasland deleted the improve-unicodeobject-error-handling branch June 11, 2023 19:29
@miss-islington

miss-islington commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in PyUnicode_BuildEncodingMap…
6ac9a8b 
…() (pythonGH-105491)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in PyUnicode_BuildEncodingMap…
c826c47 
…() (pythonGH-105491)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 11, 2023

Copy link
Copy Markdown

GH-105661 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
@bedevere-bot

bedevere-bot commented Jun 11, 2023

Copy link
Copy Markdown

GH-105662 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.12] gh-105375: Improve error handling in PyUnicode_BuildEncodingMa…
ed03895 
…p() (GH-105491) (#105661)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.11] gh-105375: Improve error handling in PyUnicode_BuildEncodingMa…
9187747 
…p() (GH-105491) (#105662)

Bail on first error to prevent exceptions from possibly being overwritten.
(cherry picked from commit 555be81)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.