GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100227: Lock Around Modification of the Global Allocators State by ericsnowcurrently · Pull Request #105516 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jun 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The risk of a race with this state is relatively low, but we play it safe anyway. We do avoid using the lock in performance-sensitive cases where the risk of a race is very, very low.

  • Issue: Improve Interpreter Isolation #100227

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 2 commits June 8, 2023 11:59
@ericsnowcurrently
Factor out LOCKS_INIT().
23137ec
@ericsnowcurrently
Add a granular lock for global allocators state.
cddd7a1
@ericsnowcurrently ericsnowcurrently added skip news needs backport to 3.12 only security fixes labels Jun 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2023
Improve Interpreter Isolation #100227
Closed
ericsnowcurrently added 2 commits June 8, 2023 12:13
@ericsnowcurrently
Merge branch 'main' into allocators-state-granular-lock
91eba44
@ericsnowcurrently
Merge branch 'main' into allocators-state-granular-lock
364fcc7
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review June 8, 2023 18:53
@bedevere-bot bedevere-bot added the awaiting core review label Jun 8, 2023
@ericsnowcurrently ericsnowcurrently removed the needs backport to 3.12 only security fixes label Jun 8, 2023
@ericsnowcurrently
ericsnowcurrently merged commit 68dfa49 into python:main Jun 8, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 8, 2023
@ericsnowcurrently
ericsnowcurrently deleted the allocators-state-granular-lock branch June 8, 2023 20:06
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.12 only security fixes label Jun 8, 2023
@miss-islington

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
@ericsnowcurrently @miss-islington
pythongh-100227: Lock Around Modification of the Global Allocators St…
f3d183f 
…ate (pythongh-105516)

The risk of a race with this state is relatively low, but we play it safe anyway. We do avoid using the lock in performance-sensitive cases where the risk of a race is very, very low.
(cherry picked from commit 68dfa49)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 8, 2023

Copy link
Copy Markdown

GH-105532 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 8, 2023
ericsnowcurrently added a commit that referenced this pull request Jun 8, 2023
@miss-islington @ericsnowcurrently
[3.12] gh-100227: Lock Around Modification of the Global Allocators S…
77c03a3 
…tate (gh-105516) (gh-105532)

The risk of a race with this state is relatively low, but we play it safe anyway. We do avoid using the lock in performance-sensitive cases where the risk of a race is very, very low.
(cherry picked from commit 68dfa49)

Co-authored-by: Eric Snow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.