GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102832: IDLE - update stackviewer open by terryjreedy · Pull Request #105528 · python/cpython

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Jun 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use 'last_exc' instead of 'last_value' in 3.12/3.

  • Issue: IDLE - Remove use of deprecated sys.last_xyzs in stackviewer #102832

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
pythongh-102832: IDLE - update stackviewer open
9a16b28 
Use 'last_exc' instead of 'last_value' in 3.12/3.
@terryjreedy terryjreedy added skip news stdlib Standard Library Python modules in the Lib/ directory needs backport to 3.12 only security fixes labels Jun 8, 2023
@terryjreedy terryjreedy self-assigned this Jun 8, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2023
IDLE - Remove use of deprecated sys.last_xyzs in stackviewer #102832
Closed
@terryjreedy

terryjreedy commented Jun 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@iritkatriel This should finish the issue. The only occurrences of the other last_xyz vars are in idlelib.run where they are set in the user globals for back-compatibility.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Jun 8, 2023
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 8, 2023
@terryjreedy
terryjreedy merged commit bb3454c into python:main Jun 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 8, 2023
@miss-islington

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
@terryjreedy @miss-islington
pythongh-102832: IDLE - update stackviewer open (pythonGH-105528)
ba93eff 
Use 'last_exc' instead of 'last_value' in 3.12/3.
(cherry picked from commit bb3454c)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 8, 2023

Copy link
Copy Markdown

GH-105534 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 8, 2023
@terryjreedy
terryjreedy deleted the valexc branch June 8, 2023 22:01
terryjreedy added a commit that referenced this pull request Jun 8, 2023
@miss-islington @terryjreedy
[3.12] gh-102832: IDLE - update stackviewer open (GH-105528) (#105534)
3eccd95 
gh-102832: IDLE - update stackviewer open (GH-105528)

Use 'last_exc' instead of 'last_value' in 3.12/3.
(cherry picked from commit bb3454c)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

skip news stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@terryjreedy @miss-islington @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.