GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105375: Improve array.array exception handling by erlend-aasland · Pull Request #105594 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix a bug where 'tp_richcompare' could end up overwriting an exception.

  • Issue: Incorrect error handling for APIs that can raise exceptions #105375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@erlend-aasland
pythongh-105375: Improve array.array exception handling
2550a00 
Fix a bug where 'tp_richcompare' could end up overwriting an exception.
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2023
Incorrect error handling for APIs that can raise exceptions #105375
Closed
18 tasks done
@erlend-aasland
erlend-aasland requested a review from sobolevn June 9, 2023 20:46
sobolevn
sobolevn approved these changes Jun 10, 2023
View reviewed changes
@erlend-aasland
erlend-aasland merged commit 35cff54 into python:main Jun 11, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 11, 2023
@miss-islington

miss-islington commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
q-o-app reacted with thumbs up emoji q-o-app reacted with laugh emoji
All reactions
  • 👍 1 reaction
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 35cff545db7c7912046c0ce5627db2e4d2b60f57 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the improve-array-error-handling branch June 11, 2023 09:58
@miss-islington miss-islington assigned erlend-aasland Jun 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve array.array exception handling (pythonGH-105594
5f3889a 
)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 11, 2023

Copy link
Copy Markdown

GH-105643 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 11, 2023
@miss-islington

miss-islington commented Jun 11, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve array.array exception handling (pythonGH-105594
04af0a7 
)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 11, 2023

Copy link
Copy Markdown

GH-105644 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.11] gh-105375: Improve array.array exception handling (GH-105594) (#…
3c08e54 
…105643)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.12] gh-105375: Improve array.array exception handling (GH-105594) (#…
d3c69ed 
…105644)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.