GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-105375: Improve PyErr_WarnExplicit() error handling by erlend-aasland · Pull Request #105610 · python/cpython

Conversation

erlend-aasland commented Jun 9, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Bail on first error to prevent exceptions from possibly being
overwritten.

Issue: Incorrect error handling for APIs that can raise exceptions #105375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reacted with thumbs up emoji

All reactions

👍 1 reaction


          pythongh-105375: Improve PyErr_WarnExplicit() error handling

Bail on first error to prevent exceptions from possibly being
overwritten.

erlend-aasland added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jun 9, 2023

erlend-aasland requested a review from sobolevn

June 9, 2023 21:36

bedevere-bot added the awaiting core review label

Jun 9, 2023

bedevere-bot mentioned this pull request

Jun 9, 2023

Incorrect error handling for APIs that can raise exceptions #105375

Closed

18 tasks done

sobolevn reviewed

Jun 10, 2023

View reviewed changes

Comment thread

Python/_warnings.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 6 commits

June 10, 2023 22:30


          Fix maybe-uinitialized warning

7fe31c2


          Pull in main

f07fce8


          'module' can also be uninitialized

91c7c6c


          Don't 'goto exit' for the first error check

d05d740


          Rewrite it

5c5100a


          Also decref 'message' and 'filename'

b7f3245

erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label

Jun 11, 2023

bedevere-bot commented Jun 11, 2023

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit b7f3245 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested a review from sobolevn

June 11, 2023 10:27

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label

Jun 11, 2023

sobolevn approved these changes

Jun 11, 2023

View reviewed changes

sobolevn left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

erlend-aasland commented Jun 11, 2023

Copy link

Copy Markdown

Contributor Author

Great, thank you!

Thanks for all the reviews! Very helpful.

sobolevn reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Jun 11, 2023

Copy link

Copy Markdown

Contributor Author

Ref. leak runs are still unusable bco. the test_import and test_peg_generator failures :(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland merged commit 567d6ae into python:main

Jun 11, 2023

bedevere-bot removed the awaiting core review label

Jun 11, 2023

miss-islington commented Jun 11, 2023

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland deleted the improve-warnings-error-handling branch

June 11, 2023 19:23

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 11, 2023


          pythongh-105375: Improve PyErr_WarnExplicit() error handling (pythonG…

0b80806

…H-105610)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <[email protected]>

bedevere-bot commented Jun 11, 2023

Copy link

Copy Markdown

GH-105659 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jun 11, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 11, 2023


          pythongh-105375: Improve PyErr_WarnExplicit() error handling (pythonG…

dc4aa1d

…H-105610)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <[email protected]>

bedevere-bot commented Jun 11, 2023

Copy link

Copy Markdown

GH-105660 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jun 11, 2023

erlend-aasland linked an issue

Jun 11, 2023

that may be closed by this pull request

Incorrect error handling for APIs that can raise exceptions #105375

Closed

18 tasks done

erlend-aasland added a commit that referenced this pull request

Jun 11, 2023


          [3.11] gh-105375: Improve PyErr_WarnExplicit() error handling (GH-105610

05c73e1

) (#105660)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <[email protected]>

erlend-aasland added a commit that referenced this pull request

Jun 11, 2023


          [3.12] gh-105375: Improve PyErr_WarnExplicit() error handling (GH-105610

db5022c

) (#105659)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <[email protected]>

Reviewers

sobolevn

sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jun 9, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jun 11, 2023

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Jun 11, 2023

Uh oh!

erlend-aasland commented Jun 11, 2023

Uh oh!

miss-islington commented Jun 11, 2023

Uh oh!

bedevere-bot commented Jun 11, 2023

Uh oh!

bedevere-bot commented Jun 11, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Jun 9, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.