GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99108: Mention HACL\* in the hashlib docs. by gpshead · Pull Request #105634 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Jun 10, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add a link to HACL* from the hashlib docs.

  • Issue: Replace built-in hashlib with verified implementations from HACL* #99108

📚 Documentation preview 📚: https://cpython-previews--105634.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
pythongh-99108: Mention HACL\* in the hashlib docs.
36f8a86
@gpshead gpshead added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes labels Jun 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 10, 2023
Replace built-in hashlib with verified implementations from HACL* #99108
Closed
@gpshead
gpshead marked this pull request as ready for review June 10, 2023 19:09
@gpshead
gpshead requested a review from tiran as a code owner June 10, 2023 19:09
@bedevere-bot bedevere-bot added the awaiting core review label Jun 10, 2023
@gpshead
gpshead merged commit 3a314f7 into python:main Jun 10, 2023
@miss-islington

miss-islington commented Jun 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 10, 2023
@gpshead
gpshead deleted the docs/hashlib-3.12-detail branch June 10, 2023 19:09
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 10, 2023
@gpshead @miss-islington
pythongh-99108: Mention HACL\* in the hashlib docs. (pythonGH-105634)
ffa415b 
(cherry picked from commit 3a314f7)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 10, 2023

Copy link
Copy Markdown

GH-105635 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 10, 2023
gpshead added a commit that referenced this pull request Jun 10, 2023
@miss-islington @gpshead
[3.12] gh-99108: Mention HACL\* in the hashlib docs. (GH-105634) (#10…
bf6e0e6 
…5635)

gh-99108: Mention HACL\* in the hashlib docs. (GH-105634)
(cherry picked from commit 3a314f7)

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gpshead @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.