GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-105708: 'V' could be case insensitive for IPvFuture hostnames by csreddy98 · Pull Request #105709 · python/cpython

gh-105708: 'V' could be case insensitive for IPvFuture hostnames #105709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

orsenthil merged 6 commits into python:main from csreddy98:IPvFuture-v-is-case-insensitive

Jul 5, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

gh-105708: 'V' could be case insensitive for IPvFuture hostnames #105709

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

6 commits

Select commit Hold shift + click to select a range

d140752

gh-105708: 'V' could be case insensitive for IPvFuture hostnames

csreddy98 Jun 12, 2023

529ee95

gh-105708: 'V' could be case insensitive for IPvFuture hostnames & ch…

csreddy98 Jun 12, 2023

d6e7564

📜🤖 Added by blurb_it.

blurb-it[bot] Jun 12, 2023

27f5102

Fix the Merge changing \z to \Z.

orsenthil Jul 5, 2026

d90aa84

Fixed the News Entry.

orsenthil Jul 5, 2026

7d47bab

Fix the lint.

orsenthil Jul 5, 2026

File filter

Filter by extension .py (2) .rst (1) All 2 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

15 changes: 10 additions & 5 deletions 15 Lib/test/test_urlparse.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -1653,15 +1653,20 @@ def test_splitting_bracketed_hosts(self):
		self.assertEqual(p1.username, 'user')
		self.assertEqual(p1.path, '/path')
		self.assertEqual(p1.port, 1234)
		p2 = urllib.parse.urlsplit('scheme://user@[0439:23af:2309::fae7%test]/path?query')
		self.assertEqual(p2.hostname, '0439:23af:2309::fae7%test')
		p2 = urllib.parse.urlsplit('scheme://user@[V6a.ip]:1234/path?query')
Comment thread orsenthil marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		self.assertEqual(p2.hostname, 'v6a.ip')
		self.assertEqual(p2.username, 'user')
		self.assertEqual(p2.path, '/path')
		self.assertIs(p2.port, None)
		p3 = urllib.parse.urlsplit('scheme://user@[0439:23af:2309::fae7:1234:192.0.2.146%test]/path?query')
		self.assertEqual(p3.hostname, '0439:23af:2309::fae7:1234:192.0.2.146%test')
		self.assertEqual(p2.port, 1234)
		p3 = urllib.parse.urlsplit('scheme://user@[0439:23af:2309::fae7%test]/path?query')
		self.assertEqual(p3.hostname, '0439:23af:2309::fae7%test')
		self.assertEqual(p3.username, 'user')
		self.assertEqual(p3.path, '/path')
		self.assertIs(p3.port, None)
		p4 = urllib.parse.urlsplit('scheme://user@[0439:23af:2309::fae7:1234:192.0.2.146%test]/path?query')
		self.assertEqual(p4.hostname, '0439:23af:2309::fae7:1234:192.0.2.146%test')
		self.assertEqual(p4.username, 'user')
		self.assertEqual(p4.path, '/path')

		def test_port_casting_failure_message(self):
		message = "Port could not be cast to integer value as 'oracle'"
Expand Down

4 changes: 2 additions & 2 deletions 4 Lib/urllib/parse.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -544,8 +544,8 @@ def _check_bracketed_netloc(netloc):
		# Valid bracketed hosts are defined in
		# https://www.rfc-editor.org/rfc/rfc3986#page-49 and https://url.spec.whatwg.org/
		def _check_bracketed_host(hostname):
		if hostname.startswith('v'):
		if not re.match(r"\Av[a-fA-F0-9]+\..+\z", hostname):
		if hostname.startswith(('v', 'V')):
		if not re.match(r"\A[vV][a-fA-F0-9]+\..+\z", hostname):
		raise ValueError(f"IPvFuture address is invalid")
		else:
		ip = ipaddress.ip_address(hostname) # Throws Value Error if not IPv6 or IPv4
Expand Down

1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Library/2023-06-12-21-31-02.gh-issue-105708.5fFwP8.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Accept an uppercase V prefix in IPvFuture addresses in :func:`urllib.parse.urlsplit`.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.