GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98040: Fix importbench: use types.ModuleType() by vstinner · Pull Request #105743 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 13, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace removed imp.new_module(name) with types.ModuleType(name).

  • Issue: Remove more deprecated importlib APIs from Python 3.12 #98040

📚 Documentation preview 📚: https://cpython-previews--105743.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-98040: Fix importbench: use types.ModuleType()
0d1f2ee 
Replace removed imp.new_module(name) with types.ModuleType(name).
@vstinner
vstinner requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners June 13, 2023 19:56
@bedevere-bot bedevere-bot added the awaiting core review label Jun 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 3, 2023
Remove more deprecated importlib APIs from Python 3.12 #98040
Closed
6 tasks done
@vstinner vstinner added needs backport to 3.12 only security fixes skip news labels Jun 13, 2023
@vstinner
vstinner merged commit 457a459 into python:main Jun 13, 2023
@miss-islington

miss-islington commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 13, 2023
@vstinner
vstinner deleted the importbench branch June 13, 2023 22:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2023
@vstinner @miss-islington
pythongh-98040: Fix importbench: use types.ModuleType() (pythonGH-105743
bc20c95 
)

Replace removed imp.new_module(name) with types.ModuleType(name).
(cherry picked from commit 457a459)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 13, 2023

Copy link
Copy Markdown

GH-105754 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 13, 2023
vstinner added a commit that referenced this pull request Jun 13, 2023
@miss-islington @vstinner
[3.12] gh-98040: Fix importbench: use types.ModuleType() (GH-105743) (#…
51b533e 
…105754)

gh-98040: Fix importbench: use types.ModuleType() (GH-105743)

Replace removed imp.new_module(name) with types.ModuleType(name).
(cherry picked from commit 457a459)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.