GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102613: Bump recursion limit to fix running test_pathlib under Coverage by ambv · Pull Request #105744 · python/cpython

Conversation

@ambv

@ambv ambv commented Jun 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Coverage adds a few frames and the previous limit was causing irrecoverable exceptions before pathlib got to its own support for recursion limit recovery.

  • Issue: Path.rglob performance issues in deeply nested directories compared to glob.glob(recursive=True) #102613

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv
pythongh-102613: Bump recursion limit to fix running test_pathlib und…
a4ad5d6 
…er Coverage
@ambv ambv added the needs backport to 3.12 only security fixes label Jun 13, 2023
@ambv
ambv requested a review from barneygale as a code owner June 13, 2023 20:04
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 13, 2023
Path.rglob performance issues in deeply nested directories compared to glob.glob(recursive=True) #102613
Closed
@ambv ambv added the skip news label Jun 13, 2023
@ambv ambv mentioned this pull request Jun 13, 2023
GH-89812: Clean up pathlib tests. #104829
Merged
@barneygale barneygale added the topic-pathlib label Jun 13, 2023
barneygale
barneygale approved these changes Jun 13, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 13, 2023
@barneygale
barneygale merged commit 4e80082 into python:main Jun 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 13, 2023
@miss-islington

miss-islington commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR, and @barneygale for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 13, 2023

Copy link
Copy Markdown

GH-105749 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2023
@ambv @miss-islington
pythongh-102613: Bump recursion limit to fix running test_pathlib und…
530af52 
…er Coverage (pythonGH-105744)

(cherry picked from commit 4e80082)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 13, 2023
barneygale pushed a commit that referenced this pull request Jun 13, 2023
@miss-islington @ambv
[3.12] gh-102613: Bump recursion limit to fix running test_pathlib un…
27426d8 
…der Coverage (GH-105744) (#105749)

gh-102613: Bump recursion limit to fix running test_pathlib under Coverage (GH-105744)
(cherry picked from commit 4e80082)

Co-authored-by: Łukasz Langa <[email protected]>
@ambv
ambv deleted the pathlib-recursion-limit branch June 13, 2023 21:23
@ambv
ambv restored the pathlib-recursion-limit branch June 20, 2023 21:20
@ambv
ambv deleted the pathlib-recursion-limit branch November 1, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale barneygale approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ambv @miss-islington @bedevere-bot @barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.