GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105745: Fix open method of webbrowser.Konqueror by sobolevn · Pull Request #105746 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

CC @DBJim

  • Issue: webbrowsers.Konqueror is broken #105745

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-105745: Fix two open methods on webbrowsers.Konqueror
63f1d0b
@sobolevn
sobolevn requested a review from vstinner June 13, 2023 20:22
@bedevere-bot bedevere-bot added the awaiting review label Jun 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 13, 2023
webbrowsers.Konqueror is broken #105745
Closed
@merwok merwok changed the title gh-105745: Fix two open methods on webbrowsers.Konqueror gh-105745: Fix open method of webbrowser.Konqueror Jun 13, 2023
vstinner
vstinner approved these changes Jun 13, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 13, 2023
@DBJim

DBJim commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Good spot!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Add news
e149290
@vstinner
vstinner merged commit e5d45b7 into python:main Jun 14, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 14, 2023
@vstinner

vstinner commented Jun 14, 2023

Copy link
Copy Markdown
Member

Merged, thanks for the quick fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DBJim

DBJim commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

Thank you both! Can we backport the fix to 3.12?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the needs backport to 3.12 only security fixes label Jun 14, 2023
@miss-islington

miss-islington commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2023
@sobolevn @miss-islington
pythongh-105745: Fix open method of webbrowser.Konqueror (pythonGH-10…
146673a 
…5746)

(cherry picked from commit e5d45b7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 14, 2023

Copy link
Copy Markdown

GH-105777 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 14, 2023
vstinner pushed a commit that referenced this pull request Jun 14, 2023
@miss-islington @sobolevn
[3.12] gh-105745: Fix open method of webbrowser.Konqueror (GH-105746) (…
ad7371e 
…#105777)

gh-105745: Fix open method of webbrowser.Konqueror (GH-105746)
(cherry picked from commit e5d45b7)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @DBJim @vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.