GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-105588: Add missing error checks to some obj2ast_* converters (GH-105589) by miss-islington · Pull Request #105839 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher [email protected]

  • Issue: Some object-to-AST conversions are missing error checks #105588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher @miss-islington
pythonGH-105588: Add missing error checks to some obj2ast_* converters (
3680071 
pythonGH-105589)

(cherry picked from commit a4056c8)

Co-authored-by: Brandt Bucher <[email protected]>
@miss-islington
miss-islington requested a review from isidentical as a code owner June 15, 2023 22:45
@bedevere-bot bedevere-bot added the awaiting review label Jun 15, 2023
This was referenced Jun 15, 2023
Some object-to-AST conversions are missing error checks #105588
Closed
GH-105588: Add missing error checks to some obj2ast_* converters #105589
Merged
@bedevere-bot bedevere-bot added the type-crash A hard crash of the interpreter, possibly with a core dump label Jun 15, 2023
@brandtbucher brandtbucher self-assigned this Jun 15, 2023
@brandtbucher
brandtbucher enabled auto-merge (squash) June 15, 2023 22:46
@brandtbucher
brandtbucher merged commit c0c4186 into python:3.11 Jun 15, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Jun 15, 2023
@miss-islington
miss-islington deleted the backport-a4056c8-3.11 branch June 15, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @bedevere-bot @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.